[simd.js] Add SIMD store functions for Phase 1.

[simd.js] Add SIMD store functions for Phase 1.

Float32x4, Int32x4, Uint32x4:
  store, store1, store2, store3

Int16x8, Int8x16, Uint16x8, Uint8x16:
  store

BUG=v8:4124
LOG=N

R=bbudge@chromium.org, littledan@chromium.org, jarin@chromium.org

Committed: https://crrev.com/ad3a8f0c5ebf5aab07b71f67e459fcd8ea5157f7
Cr-Commit-Position: refs/heads/master@{#30429}

[Dan Ehrenberg, 2015-08-26 01:18:43]

Modulo the apparent test failure, looks good to me.

[bbudge, 2015-08-26 01:28:48]

Looks good, let's wait until you rebase after landing the load CL.

The test failures are because there is no polyfill, and the load instruction CL
hasn't landed.

[bbudge, 2015-08-26 16:48:27]

bbudge@chromium.org changed reviewers:
+ bmeurer@chromium.org
- jarin@chromium.org

[gdeepti1, 2015-08-26 20:14:55]

Disabled polyfill to verify that the store functions were implemented correctly.
Re-enabling till load/store functions are added.

[Benedikt Meurer, 2015-08-27 04:34:52]

LGTM with comments.

https://codereview.chromium.org/1304183004/diff/40001/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/1304183004/diff/40001/src/parser.h#newcode1347
src/parser.h:1347: Variable* var = scope->DeclareParameter(name, mode,
is_optional,
Please revert this unrelated change.

https://codereview.chromium.org/1304183004/diff/40001/src/scopes.cc
File src/scopes.cc (right):

https://codereview.chromium.org/1304183004/diff/40001/src/scopes.cc#newcode469
src/scopes.cc:469: Variable* Scope::DeclareParameter(const AstRawString* name,
VariableMode mode,
And this one.

https://codereview.chromium.org/1304183004/diff/40001/src/scopes.h
File src/scopes.h (right):

https://codereview.chromium.org/1304183004/diff/40001/src/scopes.h#newcode132
src/scopes.h:132: bool is_optional, bool is_rest,
Also undo this change.

[gdeepti, 2015-08-27 18:49:17]

gdeepti@chromium.org changed reviewers:
+ gdeepti@chromium.org

[gdeepti, 2015-08-27 18:49:17]

https://codereview.chromium.org/1304183004/diff/40001/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/1304183004/diff/40001/src/parser.h#newcode1347
src/parser.h:1347: Variable* var = scope->DeclareParameter(name, mode,
is_optional,
On 2015/08/27 04:34:51, Benedikt Meurer wrote:
> Please revert this unrelated change.

Done.

https://codereview.chromium.org/1304183004/diff/40001/src/scopes.cc
File src/scopes.cc (right):

https://codereview.chromium.org/1304183004/diff/40001/src/scopes.cc#newcode469
src/scopes.cc:469: Variable* Scope::DeclareParameter(const AstRawString* name,
VariableMode mode,
On 2015/08/27 04:34:51, Benedikt Meurer wrote:
> And this one.

Done.

https://codereview.chromium.org/1304183004/diff/40001/src/scopes.h
File src/scopes.h (right):

https://codereview.chromium.org/1304183004/diff/40001/src/scopes.h#newcode132
src/scopes.h:132: bool is_optional, bool is_rest,
On 2015/08/27 04:34:51, Benedikt Meurer wrote:
> Also undo this change.

Done.

[bbudge, 2015-08-27 19:10:09]

LGTM w/2 tiny nits

https://codereview.chromium.org/1304183004/diff/60001/src/runtime/runtime-sim...
File src/runtime/runtime-simd.cc (right):

https://codereview.chromium.org/1304183004/diff/60001/src/runtime/runtime-sim...
src/runtime/runtime-simd.cc:963: // Load and Store functions.
nit: blank line after comment (otherwise it looks like the macro
SIMD_LOADN_STOREN_TYPES defines functions, rather than enumerating types.)

https://codereview.chromium.org/1304183004/diff/60001/src/runtime/runtime-sim...
src/runtime/runtime-simd.cc:970: // Common Load and Store Functions
nit: blank line (again, to make it clearer the comment is about the section
rather than the following macro.

[gdeepti, 2015-08-27 20:07:10]

https://codereview.chromium.org/1304183004/diff/60001/src/runtime/runtime-sim...
File src/runtime/runtime-simd.cc (right):

https://codereview.chromium.org/1304183004/diff/60001/src/runtime/runtime-sim...
src/runtime/runtime-simd.cc:963: // Load and Store functions.
On 2015/08/27 19:10:08, bbudge wrote:
> nit: blank line after comment (otherwise it looks like the macro
> SIMD_LOADN_STOREN_TYPES defines functions, rather than enumerating types.)

Done.

https://codereview.chromium.org/1304183004/diff/60001/src/runtime/runtime-sim...
src/runtime/runtime-simd.cc:970: // Common Load and Store Functions
On 2015/08/27 19:10:09, bbudge wrote:
> nit: blank line (again, to make it clearer the comment is about the section
> rather than the following macro.

Done.

[gdeepti, 2015-08-27 20:07:27]

The CQ bit was checked by gdeepti@chromium.org

[gdeepti, 2015-08-27 20:07:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/1304183004/#ps80001
(title: "Bill's comments")

[commit-bot: I haz the power, 2015-08-27 20:07:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304183004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304183004/80001

[commit-bot: I haz the power, 2015-08-27 20:33:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-27 20:33:41]

Patchset 5 (id:??) landed as
https://crrev.com/ad3a8f0c5ebf5aab07b71f67e459fcd8ea5157f7
Cr-Commit-Position: refs/heads/master@{#30429}