Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304163010: Remove harmony-atomics flag and collapse it into sharedarraybuffer flag (Closed)

Created:
5 years, 3 months ago by binji
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove harmony-atomics flag and collapse it into sharedarraybuffer flag Having both flags is tedious, and it is unlikely you'd ever want them separately. R=jarin@chromium.org Committed: https://crrev.com/196d6aeec1fcfd7e4cc06291186a65462b1f81fe Cr-Commit-Position: refs/heads/master@{#30523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M src/bootstrapper.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/asm/atomics-add.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/asm/atomics-and.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/asm/atomics-compareexchange.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/asm/atomics-exchange.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/asm/atomics-load.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/asm/atomics-or.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/asm/atomics-store.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/asm/atomics-sub.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/asm/atomics-xor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/d8-worker-sharedarraybuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/atomics.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/futex.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-501809.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
5 years, 3 months ago (2015-08-31 22:22:14 UTC) #1
Jarin
lgtm
5 years, 3 months ago (2015-09-01 09:33:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304163010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304163010/1
5 years, 3 months ago (2015-09-01 18:30:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 18:33:54 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 18:34:09 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/196d6aeec1fcfd7e4cc06291186a65462b1f81fe
Cr-Commit-Position: refs/heads/master@{#30523}

Powered by Google App Engine
This is Rietveld 408576698