Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1304163008: Revert of experiment with zero-length round capped line segments (Closed)

Created:
5 years, 4 months ago by caryclark
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of experiment with zero-length round capped line segments (patchset #4 id:60001 of https://codereview.chromium.org/1309753002/ ) Reason for revert: More GMs changed than I expected. Will probably affect layout tests as well; reverting until I can verify that the changes are correct. Original issue's description: > experiment with zero-length round capped line segments > > If the endcap is not butt, draw the endcaps even when the line > has zero length. > > If the dash length is zero, generate a zero length line segment. > > Treat a move followed by a close as a move followed by a zero-length > line. > > R=reed@google.com,schenney@google.com > BUG=422974 > > Committed: https://skia.googlesource.com/skia/+/dd3c165828fffb369d0f4b13b48381169a0249a9 TBR=reed@google.com,schenney@google.com,schenney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=422974 Committed: https://skia.googlesource.com/skia/+/21b998b181bedcd92c3a0460d29492312c0cdc89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -112 lines) Patch
M gm/strokes.cpp View 3 chunks +0 lines, -74 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/core/SkPathMeasure.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M src/core/SkStroke.cpp View 4 chunks +2 lines, -21 lines 0 comments Download
M src/utils/SkDashPath.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
caryclark
Created Revert of experiment with zero-length round capped line segments
5 years, 4 months ago (2015-08-21 20:46:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304163008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304163008/1
5 years, 4 months ago (2015-08-21 20:47:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/21b998b181bedcd92c3a0460d29492312c0cdc89
5 years, 4 months ago (2015-08-21 20:47:09 UTC) #3
caryclark
5 years, 3 months ago (2015-08-26 14:19:37 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1305313005/ by caryclark@google.com.

The reason for reverting is: Suppressed layout tests that are changed; verified
that GM changes are correct.

Powered by Google App Engine
This is Rietveld 408576698