Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: components/invalidation/impl/BUILD.gn

Issue 1304163005: Sync more GN unit tests with GYP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/guest_view/browser/BUILD.gn ('k') | components/keyed_service/content/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/invalidation/impl/BUILD.gn
diff --git a/components/invalidation/impl/BUILD.gn b/components/invalidation/impl/BUILD.gn
index 95be996861d2eca752e682854f5b19c234099a02..20034c15c02fdc90a29f62c95cc5c2ddad2de958 100644
--- a/components/invalidation/impl/BUILD.gn
+++ b/components/invalidation/impl/BUILD.gn
@@ -5,7 +5,7 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
-static_library("impl") {
+source_set("impl") {
sources = [
"invalidation_logger.cc",
"invalidation_logger.h",
@@ -91,14 +91,39 @@ static_library("impl") {
}
}
-group("unittests") {
+source_set("unit_tests") {
testonly = true
+ sources = [
+ "invalidation_logger_unittest.cc",
+ ]
deps = [
":impl",
":test_support",
+ "//testing/gmock",
+ "//testing/gtest",
]
+
if (is_android) {
+ sources += [ "invalidation_service_android_unittest.cc" ]
deps += [ ":jni_headers" ]
+ } else {
+ # Non-Android tests.
+ sources += [
+ "fake_invalidator_unittest.cc",
+ "gcm_network_channel_unittest.cc",
+ "invalidation_notifier_unittest.cc",
+ "invalidator_registrar_unittest.cc",
+ "non_blocking_invalidator_unittest.cc",
+ "object_id_invalidation_map_unittest.cc",
+ "p2p_invalidator_unittest.cc",
+ "push_client_channel_unittest.cc",
+ "registration_manager_unittest.cc",
+ "single_object_invalidation_set_unittest.cc",
+ "sync_invalidation_listener_unittest.cc",
+ "sync_system_resources_unittest.cc",
+ "ticl_invalidation_service_unittest.cc",
+ "unacked_invalidation_set_unittest.cc",
+ ]
}
}
@@ -123,13 +148,17 @@ static_library("test_support") {
"unacked_invalidation_set_test_util.h",
]
+ public_deps = [
+ ":impl",
+ "//jingle:notifier_test_util",
+ "//third_party/cacheinvalidation",
+ ]
deps = [
"//base",
"//components/gcm_driver:test_support",
"//components/keyed_service/core",
"//google_apis",
"//jingle:notifier",
- "//jingle:notifier_test_util",
"//net",
"//testing/gmock",
@@ -138,9 +167,6 @@ static_library("test_support") {
# "//third_party/cacheinvalidation/src/google/cacheinvalidation:cacheinvalidation_proto_cpp",
]
- public_deps = [
- "//third_party/cacheinvalidation",
- ]
if (is_android) {
deps += [ ":jni_headers" ]
« no previous file with comments | « components/guest_view/browser/BUILD.gn ('k') | components/keyed_service/content/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698