Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304163005: Sync more GN unit tests with GYP. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, wjmaclean, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, browser-components-watch_chromium.org, maxbogue+watch_chromium.org, jam, chromium-apps-reviews_chromium.org, plaree+watch_chromium.org, darin-cc_chromium.org, noyau+watch_chromium.org, asvitkine+watch_chromium.org, tfarina, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync more GN unit tests with GYP. This adds about 600 more tests. Tests added: invalidation, navigation interception, feedback, search, sync driver, enhanced bookmarks, search engines, sessions, data reduction proxy, favicon, constrained window, autofill, metrics, keyed service, bookmarks, suggestions, audio modem I renamed ui_zoom to "zoom" according to GN style. I tweaked some jingle public dependencies so the right include directories get forwarded along with the corresponding uses in the headers. Reland of http://crrev.com/1301743003 TBR=dpranke@chromium.org Committed: https://crrev.com/0741cb1c9b944e7a218a84870bdc177a72cb2998 Cr-Commit-Position: refs/heads/master@{#344874}

Patch Set 1 : Original patch #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -75 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 7 chunks +17 lines, -3 lines 0 comments Download
M components/audio_modem/BUILD.gn View 1 4 chunks +26 lines, -4 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/browser/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/constrained_window/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/enhanced_bookmarks/BUILD.gn View 1 chunk +15 lines, -1 line 0 comments Download
M components/favicon/content/BUILD.gn View 2 chunks +16 lines, -2 lines 0 comments Download
M components/favicon/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/BUILD.gn View 2 chunks +17 lines, -1 line 0 comments Download
M components/guest_view/browser/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M components/invalidation/impl/BUILD.gn View 4 chunks +32 lines, -6 lines 0 comments Download
M components/keyed_service/content/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M components/keyed_service/core/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M components/metrics/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M components/navigation_interception/BUILD.gn View 2 chunks +14 lines, -1 line 0 comments Download
M components/rappor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/search/BUILD.gn View 2 chunks +13 lines, -1 line 0 comments Download
M components/search_engines/BUILD.gn View 1 chunk +20 lines, -1 line 0 comments Download
M components/sessions/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M components/suggestions/BUILD.gn View 3 chunks +23 lines, -6 lines 0 comments Download
M components/sync_driver/BUILD.gn View 4 chunks +36 lines, -35 lines 0 comments Download
M components/ui/zoom/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/ui_zoom.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/web_modal/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M jingle/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M pdf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
brettw
5 years, 4 months ago (2015-08-21 15:58:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304163005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304163005/20001
5 years, 4 months ago (2015-08-21 15:59:08 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (JOB_FAILED, no build URL)
5 years, 4 months ago (2015-08-21 16:01:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304163005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304163005/20001
5 years, 4 months ago (2015-08-21 16:16:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102381)
5 years, 4 months ago (2015-08-21 17:39:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304163005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304163005/20001
5 years, 4 months ago (2015-08-21 20:54:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-21 22:06:09 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 22:06:53 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0741cb1c9b944e7a218a84870bdc177a72cb2998
Cr-Commit-Position: refs/heads/master@{#344874}

Powered by Google App Engine
This is Rietveld 408576698