Plumbing SSLPrivateKey

net/ssl/ssl_platform_key.h

Index: net/ssl/ssl_platform_key.h
diff --git a/net/ssl/ssl_platform_key.h b/net/ssl/ssl_platform_key.h
index bcab6a4c32d0c9b355fe364915ca1095fb4eba89..ce1f800f7d494e1f387d7426fe085cdf1b55c5a2 100644
--- a/net/ssl/ssl_platform_key.h
+++ b/net/ssl/ssl_platform_key.h
@@ -5,8 +5,14 @@
 #ifndef NET_SSL_SSL_PLATFORM_KEY_H_
 #define NET_SSL_SSL_PLATFORM_KEY_H_
 
+#include "base/lazy_instance.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
+#include "net/base/net_export.h"
+
+#if defined(OS_ANDROID)
+#include "crypto/scoped_openssl_types.h"
+#endif
 
 namespace base {
 class SequencedTaskRunner;
@@ -17,13 +23,18 @@ namespace net {
 class SSLPrivateKey;
 class X509Certificate;
 
+#if defined(OS_ANDROID)
+// Wraps a ScopedEVP_PKEY into an SSLPrivateKey.
+NET_EXPORT scoped_refptr<SSLPrivateKey> WrapOpenSSLPrivateKey(
+    crypto::ScopedEVP_PKEY key);
+#else
 // Looks up the private key from the platform key store corresponding to
 // |certificate|'s public key and returns an SSLPrivateKey which offloads
-// signing operations to |task_runner|. |task_runner| is a SequencedTaskRunner
-// to allow for buggy third-party smartcard drivers.
-scoped_ptr<SSLPrivateKey> FetchClientCertPrivateKey(
-    X509Certificate* certificate,
-    scoped_refptr<base::SequencedTaskRunner> task_runner);
+// signing operations to the |g_platform_key_task_runner| to account for
+// buggy smartcards.

[davidben, 2015/10/13 20:32:16]

What is g_platform_key_task_runner? This header doesn't include or reference it.

Actually, I think as a caller of this function, you don't even care about this
behavior, so you can just write "and returns an SSLPrivateKey backed by the
platform key"

[svaldez, 2015/10/14 15:06:19]

Done.

+NET_EXPORT scoped_refptr<SSLPrivateKey> FetchClientCertPrivateKey(
+    X509Certificate* certificate);
+#endif
 
 }  // namespace net