Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2917)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/ssl/client_cert_store_win.cc

Issue 1304143010: Plumbing SSLPrivateKey Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing unused function in Android. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/socket/ssl_client_socket_openssl_unittest.cc ('K') | « net/socket/ssl_client_socket_openssl_unittest.cc ('k') | net/ssl/client_key_store.h » ('j') | net/ssl/ssl_client_auth_cache_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/client_cert_store_win.cc
diff --git a/net/ssl/client_cert_store_win.cc b/net/ssl/client_cert_store_win.cc
index 2e9763ffdb269b77ac58c18735ece8f04ceb053f..4bba66857affe4177689090fd9eccafa014234d3 100644
--- a/net/ssl/client_cert_store_win.cc
+++ b/net/ssl/client_cert_store_win.cc
@@ -129,6 +129,11 @@ void GetClientCertsImpl(HCERTSTORE cert_store,
if (ok)
intermediates.push_back(copied_intermediate);
}
+ // TODO(svaldez): cert currently wraps cert_context2 which may be backed
+ // by a smartcard with threading difficulties. Instead, create a fresh
+ // X509Certificate with CreateFromBytes and route cert_context2 into the
+ // SSLPrivateKey. Probably changing CertificateList to be a
+ // pair<X509Certificate, SSLPrivateKeyCallback>.
scoped_refptr<X509Certificate> cert = X509Certificate::CreateFromHandle(
cert_context2, intermediates);
selected_certs->push_back(cert);
« net/socket/ssl_client_socket_openssl_unittest.cc ('K') | « net/socket/ssl_client_socket_openssl_unittest.cc ('k') | net/ssl/client_key_store.h » ('j') | net/ssl/ssl_client_auth_cache_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698