Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2007)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 1304143010: Plumbing SSLPrivateKey Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 72cb56e256be50a96901dc47a68cad2f2cbf6d77..c364f3e6d19c0ece720ab35847c2453783febdee 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -75,6 +75,7 @@
#include "net/socket/ssl_client_socket.h"
#include "net/ssl/ssl_cipher_suite_names.h"
#include "net/ssl/ssl_connection_status_flags.h"
+#include "net/ssl/ssl_private_key.h"
davidben 2015/09/25 20:10:12 Nit: unnecessary
svaldez 2015/09/28 16:54:54 Done.
#include "net/test/cert_test_util.h"
#include "net/test/spawned_test_server/spawned_test_server.h"
#include "net/url_request/data_protocol_handler.h"
@@ -7964,7 +7965,7 @@ TEST_F(HTTPSRequestTest, ClientAuthTest) {
// Send no certificate.
// TODO(davidben): Get temporary client cert import (with keys) working on
// all platforms so we can test sending a cert as well.
- r->ContinueWithCertificate(NULL);
+ r->ContinueWithCertificate(NULL, NULL);
davidben 2015/09/25 20:10:12 Nit: while you're here, want to make this nullptr?
svaldez 2015/09/28 16:54:54 Done.
base::RunLoop().Run();

Powered by Google App Engine
This is Rietveld 408576698