chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm - Issue 1304143010: Plumbing SSLPrivateKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

Issue 1304143010: Plumbing SSLPrivateKey Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix rebase. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/ssl_client_certificate_request.cc ('k') | chromecast/browser/cast_content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

index ff5088970c423cb10ce364e889b19d0eb3721f90..30a25f6485bc418cab4a8c58da1db4418c04b6ba 100644

--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

@@ -39,7 +39,8 @@ class TestClientCertificateDelegate

}

// content::ClientCertificateDelegate.

- void ContinueWithCertificate(net::X509Certificate* cert) override {

+ void ContinueWithCertificate(net::X509Certificate* cert,

+ net::SSLPrivateKey* private_key) override {

// TODO(davidben): Add a test which explicitly tests selecting a

// certificate, or selecting no certificate, since closing the dialog

// (normally by closing the tab) is not the same as explicitly selecting no

« no previous file with comments | « chrome/browser/ui/android/ssl_client_certificate_request.cc ('k') | chromecast/browser/cast_content_browser_client.h » ('j') | no next file with comments »