Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1304103002: Replace ASSERT(!isScriptForbbiden()) in MicroTaskSuppression with RELEASE_ASSERT (Closed)

Created:
5 years, 4 months ago by haraken
Modified:
5 years, 4 months ago
Reviewers:
esprehn, yurys
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace ASSERT(!isScriptForbbiden()) in MicroTaskSuppression with RELEASE_ASSERT We normally use RELEASE_ASSERT for checking !isScriptForbbiden() because executing a script in places where script execution is not allowed can lead to security issues. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/bindings/core/v8/V8RecursionScope.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL
5 years, 4 months ago (2015-08-21 07:38:33 UTC) #2
esprehn
lgtm
5 years, 4 months ago (2015-08-21 09:55:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304103002/1
5 years, 4 months ago (2015-08-21 12:03:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200984
5 years, 4 months ago (2015-08-21 13:37:39 UTC) #7
yurys
5 years, 4 months ago (2015-08-21 14:13:28 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698