Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304093006: Add a new API for testing animated images (Closed)

Created:
5 years, 3 months ago by pdr.
Modified:
5 years, 3 months ago
Reviewers:
chrishtr, fs, ojan
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Rik, Inactive, danakj, dshwang, drott+blinkwatch_chromium.org, krit, Eric Willigers, f(malita), fs, gyuyoung2, jbroman, Justin Novosad, kouhei+svg_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Add a new API for testing animated images This patch adds internals.advanceImageAnimationFrame([img]) for advancing an image's animation in tests. With this patch, 2.5 seconds of unnecessary and flaky setTimeout calls have been removed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201942

Patch Set 1 #

Patch Set 2 : Revert one test #

Patch Set 3 : More tests #

Patch Set 4 : Minor updates and cleanup #

Patch Set 5 : Minor cleanup #

Patch Set 6 : Minor cleanup #

Patch Set 7 : Higher expectations #

Patch Set 8 : Cleanup tests #

Total comments: 9

Patch Set 9 : Rebase, address reviewer comments #

Patch Set 10 : Rebase harder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -97 lines) Patch
M LayoutTests/OilpanExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/canvas/philip/tests/2d.drawImage.animated.gif.html View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html View 1 2 3 4 5 1 chunk +10 lines, -12 lines 0 comments Download
A LayoutTests/fast/images/animated-gif-advance-frames.html View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/images/animated-gif-advance-frames-expected.html View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/images/resources/green-red-blue-yellow-animated.gif View 9 Binary file 0 comments Download
M LayoutTests/paint/invalidation/animated-gif.html View 1 2 1 chunk +5 lines, -16 lines 0 comments Download
M LayoutTests/paint/invalidation/animated-gif-background.html View 1 2 1 chunk +5 lines, -16 lines 0 comments Download
M LayoutTests/platform/linux/svg/repaint/image-animation-with-zoom-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/svg/repaint/image-animation-with-zoom-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/svg/as-image/animated-svg-animation-control.html View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/svg/as-image/animated-svg-animation-control-expected.html View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/svg/as-image/animated-svg-as-image.html View 1 2 3 4 5 6 7 8 2 chunks +10 lines, -5 lines 0 comments Download
M LayoutTests/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -4 lines 0 comments Download
M LayoutTests/svg/as-image/animated-svg-as-image-same-image.html View 1 2 3 4 5 6 7 8 2 chunks +10 lines, -5 lines 0 comments Download
M LayoutTests/svg/as-image/animated-use-as-image-crash.html View 1 2 3 4 5 6 7 1 chunk +7 lines, -2 lines 0 comments Download
M LayoutTests/svg/repaint/image-animation-with-zoom.html View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/svg/repaint/image-animation-with-zoom-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 2 3 4 5 6 7 8 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/graphics/BitmapImage.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/graphics/Image.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304093006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304093006/80001
5 years, 3 months ago (2015-09-06 06:19:29 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/108842)
5 years, 3 months ago (2015-09-06 08:11:13 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304093006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304093006/100001
5 years, 3 months ago (2015-09-06 22:13:38 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/108866)
5 years, 3 months ago (2015-09-07 00:00:46 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304093006/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304093006/140001
5 years, 3 months ago (2015-09-07 00:17:16 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-07 01:26:54 UTC) #12
pdr.
5 years, 3 months ago (2015-09-07 22:56:05 UTC) #14
fs
Maybe a little wiggly (preferably we'd just advance the timeline and be done with it ...
5 years, 3 months ago (2015-09-08 14:50:57 UTC) #15
chrishtr
lgtm
5 years, 3 months ago (2015-09-08 17:00:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304093006/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304093006/160001
5 years, 3 months ago (2015-09-08 22:50:04 UTC) #19
pdr.
https://codereview.chromium.org/1304093006/diff/140001/LayoutTests/svg/as-image/animated-svg-as-image.html File LayoutTests/svg/as-image/animated-svg-as-image.html (right): https://codereview.chromium.org/1304093006/diff/140001/LayoutTests/svg/as-image/animated-svg-as-image.html#newcode13 LayoutTests/svg/as-image/animated-svg-as-image.html:13: // The animation lasts 100ms so skip 12 frames ...
5 years, 3 months ago (2015-09-08 22:50:38 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/108883) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-08 22:51:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304093006/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304093006/180001
5 years, 3 months ago (2015-09-08 22:57:47 UTC) #25
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 00:08:45 UTC) #26
Message was sent while issue was closed. 
Committed patchset #10 (id:180001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201942

Powered by Google App Engine
This is Rietveld 408576698