Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1304093005: Reland of OOPIF: Call setCoreFrame on remote-to-local swaps. (Closed)

Created:
5 years, 3 months ago by falken
Modified:
5 years, 3 months ago
Reviewers:
alexmos, dcheng
CC:
blink-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland of OOPIF: Call setCoreFrame on remote-to-local swaps. (patchset #1 id:1 of https://codereview.chromium.org/1315543009/ ) Reason for revert: Reland: The Android build went green one build before this revert. Original issue's description: > Revert of OOPIF: Call setCoreFrame on remote-to-local swaps. (patchset #4 id:60001 of https://codereview.chromium.org/1316863009/ ) > > Reason for revert: > I suspect this change broke webkit_unit_tests on Nexus 4: > All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/0 > All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/1 > All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/0 > All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/1 > All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForMinimumScale/0 > All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForWidthEqualsDeviceWidth/1 > All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedLayout/1 > > First failing build: > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/37423 > > Blamelist: > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=201725:201728&mode=html > http://test-results.appspot.com/revision_range?start=347178&end=347178 > > Original issue's description: > > OOPIF: Call setCoreFrame on remote-to-local swaps. > > > > This ensures that various initializion in setCoreFrame is triggered when > > doing remote-to-local swaps. > > > > BUG=525285 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201726 > > TBR=dcheng@chromium.org,alexmos@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=525285 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201756 TBR=dcheng@chromium.org,alexmos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=525285 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +9 lines, -7 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
falken
Created Reland of OOPIF: Call setCoreFrame on remote-to-local swaps.
5 years, 3 months ago (2015-09-04 07:48:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304093005/1
5 years, 3 months ago (2015-09-04 07:48:55 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 07:49:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201781

Powered by Google App Engine
This is Rietveld 408576698