Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304083006: Fix SkOneShotDiscardablePixelRef to return discardable segment. (Closed)

Created:
5 years, 3 months ago by ssid
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SkOneShotDiscardablePixelRef to return discardable segment. The SkOneShotDiscardablePixelRef was not overriding diagnostic_only_getDiscardable method of SkPixelRef. This caused the memory to be acocunted under malloc instead of discardable and caused wrong accounting. BUG=528295 Committed: https://skia.googlesource.com/skia/+/85237822b3f736e1738b5791227a2d6656137f23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/core/SkResourceCache.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ssid
One line fix, PTAL, thanks.
5 years, 3 months ago (2015-09-04 15:12:42 UTC) #2
reed1
lgtm
5 years, 3 months ago (2015-09-04 15:21:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304083006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304083006/1
5 years, 3 months ago (2015-09-04 15:24:49 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 15:29:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/85237822b3f736e1738b5791227a2d6656137f23

Powered by Google App Engine
This is Rietveld 408576698