Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1304073006: Revert of Add WebCache memory usage in Blink to chrome://tracing (Closed)

Created:
5 years, 3 months ago by ssid
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@discardable_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add WebCache memory usage in Blink to chrome://tracing Original CL: www.crrev.com/1283793004 Reason for revert: Move to blink. The memory cache in blink allocates from PartitionAlloc for encoded data and uses discardable for decoded 8images. To set the sub-allocation edges correctly, this has to be moved inside blink. Blink side CL: crrev.com/1327793003. TBR=thestig@chromium.org, jam@chromium.org BUG=520842 Committed: https://crrev.com/18ef6deb4977e855c3b91502a231232caadcbde6 Cr-Commit-Position: refs/heads/master@{#347383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -135 lines) Patch
M components/web_cache.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/web_cache/renderer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/web_cache/renderer/web_cache_memory_dump_provider.h View 1 chunk +0 lines, -33 lines 0 comments Download
D components/web_cache/renderer/web_cache_memory_dump_provider.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M components/web_cache/renderer/web_cache_render_process_observer.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
ssid
Hi, sorry for the revert of this change. This has to be moved inside blink ...
5 years, 3 months ago (2015-09-02 13:23:18 UTC) #2
Primiano Tucci (use gerrit)
LGTM, diffed the original cl and this one. I think you can not bother the ...
5 years, 3 months ago (2015-09-04 09:14:37 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304073006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304073006/1
5 years, 3 months ago (2015-09-04 10:14:37 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-04 11:32:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304073006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304073006/1
5 years, 3 months ago (2015-09-04 11:36:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 11:40:24 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 11:41:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18ef6deb4977e855c3b91502a231232caadcbde6
Cr-Commit-Position: refs/heads/master@{#347383}

Powered by Google App Engine
This is Rietveld 408576698