Split tests in navigation-redirect.html to each different promise_tests.

Split tests in navigation-redirect.html to each different promise_tests.

It would be helpful to upstream the tests to WPT tests.

BUG=522836
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201384

[horo, 2015-08-21 05:36:53]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2015-08-21 05:36:53]

falken@
Could you please review this?

[falken, 2015-08-26 07:25:48]

lgtm, thanks for working on this

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
File LayoutTests/http/tests/serviceworker/navigation-redirect.html (right):

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/navigation-redirect.html:48:
add_completion_callback(function() {
ahh.. that's a handy function

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/navigation-redirect.html:60:
send_to_iframe(other_origin_frame, "wait_for_worker")]);
single quotes

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/navigation-redirect.html:84:
.then(function(urls) {
indent looks wrong

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/navigation-redirect.html:95:
message_resolvers['last_url'] = resolve;
maybe message_resolvers and the other globals should be declared before this, up
top

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/navigation-redirect.html:148: OUT_SCOPE +
"url=" + encodeURIComponent(SCOPE1),
double quotes should be single quotes here and throughout

[horo, 2015-08-28 05:27:49]

The CQ bit was checked by horo@chromium.org

[horo, 2015-08-28 05:27:49]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1304073002/#ps20001
(title: "incorporated falken's comment")

[commit-bot: I haz the power, 2015-08-28 05:28:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304073002/20001

[horo, 2015-08-28 07:05:41]

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
File LayoutTests/http/tests/serviceworker/navigation-redirect.html (right):

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/navigation-redirect.html:60:
send_to_iframe(other_origin_frame, "wait_for_worker")]);
On 2015/08/26 07:25:48, falken wrote:
> single quotes

Done.

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/navigation-redirect.html:84:
.then(function(urls) {
On 2015/08/26 07:25:48, falken wrote:
> indent looks wrong

Changed the position of brackets.

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/navigation-redirect.html:95:
message_resolvers['last_url'] = resolve;
On 2015/08/26 07:25:48, falken wrote:
> maybe message_resolvers and the other globals should be declared before this,
up
> top

Done.

https://codereview.chromium.org/1304073002/diff/1/LayoutTests/http/tests/serv...
LayoutTests/http/tests/serviceworker/navigation-redirect.html:148: OUT_SCOPE +
"url=" + encodeURIComponent(SCOPE1),
On 2015/08/26 07:25:48, falken wrote:
> double quotes should be single quotes here and throughout

Done.

[horo, 2015-08-28 08:49:36]

The CQ bit was checked by horo@chromium.org

[horo, 2015-08-28 08:49:36]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1304073002/#ps20001
(title: "incorporated falken's comment")

[commit-bot: I haz the power, 2015-08-28 08:49:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304073002/20001

[commit-bot: I haz the power, 2015-08-28 08:54:01]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201384