Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1304063015: [refactor] Rename the webcrypto/openssl and webcrypto/test directories. (Closed)

Created:
5 years, 3 months ago by eroman
Modified:
5 years, 3 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@jwk_refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[refactor] Rename the webcrypto/openssl and webcrypto/test directories. Since there is no longer an NSS vs OpenSSL distinction, merge these directories into a single "algorithms/" directory, and also simplify the filenames by dropping the _openssl suffix. For example whereas before it looked like: openssl/ rsa_oaep_openssl.cc test/ rsa_oaep_unittest.cc Now it looks like: algorithms/ rsa_oaep.cc rsa_oaep_unittest.cc BUG=519504 Committed: https://crrev.com/7bcd6a790cbfeecedce48ee6d7c7bef453f1784d Cr-Commit-Position: refs/heads/master@{#349072}

Patch Set 1 #

Total comments: 6

Patch Set 2 : fix some header guards #

Patch Set 3 : rebase onto master #

Patch Set 4 : fix filename in gn build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -9840 lines) Patch
M components/components_tests.gyp View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M components/webcrypto/BUILD.gn View 1 2 3 2 chunks +39 lines, -39 lines 0 comments Download
A + components/webcrypto/algorithms/aes.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/aes.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/aes_cbc.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/aes_cbc_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/aes_ctr.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/aes_ctr_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/aes_gcm.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/webcrypto/algorithms/aes_gcm_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/aes_kw.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/webcrypto/algorithms/aes_kw_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/ec.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/ec.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/ecdh.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/ecdh_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/ecdsa.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/ecdsa_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/hkdf.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/webcrypto/algorithms/hmac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/webcrypto/algorithms/hmac_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/key.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/key.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/pbkdf2.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/webcrypto/algorithms/rsa.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/rsa.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/rsa_oaep.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/rsa_oaep_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/rsa_pss.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/webcrypto/algorithms/rsa_pss_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/rsa_sign.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/rsa_sign.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/rsa_ssa.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/webcrypto/algorithms/rsa_ssa_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/sha.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/webcrypto/algorithms/sha_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/test_helpers.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/test_helpers.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + components/webcrypto/algorithms/util_openssl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webcrypto/algorithms/util_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D components/webcrypto/openssl/aes_algorithm_openssl.h View 1 chunk +0 lines, -78 lines 0 comments Download
D components/webcrypto/openssl/aes_algorithm_openssl.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D components/webcrypto/openssl/aes_cbc_openssl.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D components/webcrypto/openssl/aes_ctr_openssl.cc View 1 chunk +0 lines, -268 lines 0 comments Download
D components/webcrypto/openssl/aes_gcm_openssl.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D components/webcrypto/openssl/aes_kw_openssl.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D components/webcrypto/openssl/ec_algorithm_openssl.h View 1 chunk +0 lines, -82 lines 0 comments Download
D components/webcrypto/openssl/ec_algorithm_openssl.cc View 1 chunk +0 lines, -566 lines 0 comments Download
D components/webcrypto/openssl/ecdh_openssl.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D components/webcrypto/openssl/ecdsa_openssl.cc View 1 chunk +0 lines, -266 lines 0 comments Download
D components/webcrypto/openssl/hkdf_openssl.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D components/webcrypto/openssl/hmac_openssl.cc View 1 chunk +0 lines, -244 lines 0 comments Download
D components/webcrypto/openssl/key_openssl.h View 1 chunk +0 lines, -79 lines 0 comments Download
D components/webcrypto/openssl/key_openssl.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D components/webcrypto/openssl/pbkdf2_openssl.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D components/webcrypto/openssl/rsa_hashed_algorithm_openssl.h View 1 chunk +0 lines, -90 lines 0 comments Download
D components/webcrypto/openssl/rsa_hashed_algorithm_openssl.cc View 1 2 1 chunk +0 lines, -515 lines 0 comments Download
D components/webcrypto/openssl/rsa_oaep_openssl.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D components/webcrypto/openssl/rsa_pss_openssl.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D components/webcrypto/openssl/rsa_sign_openssl.h View 1 chunk +0 lines, -40 lines 0 comments Download
D components/webcrypto/openssl/rsa_sign_openssl.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D components/webcrypto/openssl/rsa_ssa_openssl.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D components/webcrypto/openssl/sha_openssl.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D components/webcrypto/openssl/util_openssl.h View 1 chunk +0 lines, -101 lines 0 comments Download
D components/webcrypto/openssl/util_openssl.cc View 1 chunk +0 lines, -251 lines 0 comments Download
M components/webcrypto/platform_crypto.h View 2 chunks +4 lines, -1 line 0 comments Download
A + components/webcrypto/status_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/webcrypto/test/aes_cbc_unittest.cc View 1 2 1 chunk +0 lines, -568 lines 0 comments Download
D components/webcrypto/test/aes_ctr_unittest.cc View 1 2 1 chunk +0 lines, -170 lines 0 comments Download
D components/webcrypto/test/aes_gcm_unittest.cc View 1 2 1 chunk +0 lines, -222 lines 0 comments Download
D components/webcrypto/test/aes_kw_unittest.cc View 1 2 1 chunk +0 lines, -538 lines 0 comments Download
D components/webcrypto/test/ecdh_unittest.cc View 1 2 1 chunk +0 lines, -367 lines 0 comments Download
D components/webcrypto/test/ecdsa_unittest.cc View 1 2 1 chunk +0 lines, -377 lines 0 comments Download
D components/webcrypto/test/hmac_unittest.cc View 1 2 1 chunk +0 lines, -602 lines 0 comments Download
D components/webcrypto/test/rsa_oaep_unittest.cc View 1 2 1 chunk +0 lines, -505 lines 0 comments Download
D components/webcrypto/test/rsa_pss_unittest.cc View 1 2 1 chunk +0 lines, -259 lines 0 comments Download
D components/webcrypto/test/rsa_ssa_unittest.cc View 1 2 1 chunk +0 lines, -1020 lines 0 comments Download
D components/webcrypto/test/sha_unittest.cc View 1 2 1 chunk +0 lines, -84 lines 0 comments Download
D components/webcrypto/test/status_unittest.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D components/webcrypto/test/test_helpers.h View 1 2 1 chunk +0 lines, -211 lines 0 comments Download
D components/webcrypto/test/test_helpers.cc View 1 2 1 chunk +0 lines, -648 lines 0 comments Download
M components/webcrypto/webcrypto.gyp View 1 chunk +25 lines, -25 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
eroman
5 years, 3 months ago (2015-09-05 02:30:16 UTC) #2
davidben
lgtm! https://codereview.chromium.org/1304063015/diff/1/components/webcrypto/algorithms/rsa_sign.h File components/webcrypto/algorithms/rsa_sign.h (right): https://codereview.chromium.org/1304063015/diff/1/components/webcrypto/algorithms/rsa_sign.h#newcode6 components/webcrypto/algorithms/rsa_sign.h:6: #define COMPONENTS_WEBCRYPTO_OPENSSL_RSA_SIGN_OPENSSL_H_ COMPONENTS_WEBCRYPTO_ALGORITHMS_RSA_SIGN_H_ https://codereview.chromium.org/1304063015/diff/1/components/webcrypto/algorithms/test_helpers.h File components/webcrypto/algorithms/test_helpers.h (right): https://codereview.chromium.org/1304063015/diff/1/components/webcrypto/algorithms/test_helpers.h#newcode6 ...
5 years, 3 months ago (2015-09-15 19:40:29 UTC) #3
eroman
https://codereview.chromium.org/1304063015/diff/1/components/webcrypto/algorithms/rsa_sign.h File components/webcrypto/algorithms/rsa_sign.h (right): https://codereview.chromium.org/1304063015/diff/1/components/webcrypto/algorithms/rsa_sign.h#newcode6 components/webcrypto/algorithms/rsa_sign.h:6: #define COMPONENTS_WEBCRYPTO_OPENSSL_RSA_SIGN_OPENSSL_H_ On 2015/09/15 19:40:29, David Benjamin wrote: > ...
5 years, 3 months ago (2015-09-15 20:53:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304063015/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304063015/40001
5 years, 3 months ago (2015-09-16 01:24:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304063015/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304063015/60001
5 years, 3 months ago (2015-09-16 01:30:36 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-16 02:41:30 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/7bcd6a790cbfeecedce48ee6d7c7bef453f1784d Cr-Commit-Position: refs/heads/master@{#349072}
5 years, 3 months ago (2015-09-16 02:42:15 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:53:17 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7bcd6a790cbfeecedce48ee6d7c7bef453f1784d
Cr-Commit-Position: refs/heads/master@{#349072}

Powered by Google App Engine
This is Rietveld 408576698