components/view_manager/server_view.cc - Issue 1304063014: cc: Plumbing for BeginFrameSource based on Surfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/server_view.cc

Issue 1304063014: cc: Plumbing for BeginFrameSource based on Surfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SurfaceAggregator tests; fix some bugs revealed by tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/surfaces/surface_factory.cc ('K') | « components/view_manager/server_view.h ('k') | components/view_manager/surfaces/top_level_display_client.h » ('j') | components/view_manager/surfaces/top_level_display_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/view_manager/server_view.cc

diff --git a/components/view_manager/server_view.cc b/components/view_manager/server_view.cc

index 8c4f69d80713464a82dc1429807cc3f1feab6dcb..0ffeb57857e5d4e5e5bb9a902d8f4141be3b2b71 100644

--- a/components/view_manager/server_view.cc

+++ b/components/view_manager/server_view.cc

@@ -310,6 +310,10 @@ void ServerView::ReturnResources(

mojo::Array<mojo::ReturnedResourcePtr>::From(resources));

}

+void ServerView::SetBeginFrameSource(cc::BeginFrameSource* begin_frame_source) {

+ // TODO(tansell): Implement this.

sky 2015/09/24 23:58:20 NOTIMPLEMENTED if it won't be too spammy.

void ServerView::RemoveImpl(ServerView* view) {

view->parent_ = NULL;

children_.erase(std::find(children_.begin(), children_.end(), view));