Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304063005: Make classes and structures in core/page fast-allocated. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, dcheng
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in core/page fast-allocated. Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M Source/core/page/AutoscrollController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/DOMWindowPagePopup.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/DragSession.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/PageSerializer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/PrintContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/ScopedPageLoadDeferrer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/WindowFeatures.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollingConstraints.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-08-27 07:57:22 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-08-27 08:57:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304063005/1
5 years, 3 months ago (2015-08-28 04:10:45 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 07:00:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201379

Powered by Google App Engine
This is Rietveld 408576698