Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304033003: [DevTools] Fixed output of string consisting multiple spaces (Closed)

Created:
5 years, 4 months ago by kozy
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Fixed output of string consisting multiple spaces " ".repeat(10) will produce string with one space in console output. This CL changed this behavior by replacing white-space:nowrap rule to white-space:pre. BUG=516989 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/components/objectValue.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
kozy
Pavel, please take a look.
5 years, 4 months ago (2015-08-25 00:01:22 UTC) #1
pfeldman
Are you saying no tests were affected?
5 years, 4 months ago (2015-08-25 00:46:31 UTC) #2
kozy
On 2015/08/25 00:46:31, pfeldman wrote: > Are you saying no tests were affected? Yes, created ...
5 years, 4 months ago (2015-08-25 00:54:12 UTC) #3
pfeldman
lgtm
5 years, 4 months ago (2015-08-25 00:56:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304033003/1
5 years, 4 months ago (2015-08-25 00:56:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103495)
5 years, 4 months ago (2015-08-25 02:00:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304033003/1
5 years, 4 months ago (2015-08-25 02:03:50 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 02:44:54 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201091

Powered by Google App Engine
This is Rietveld 408576698