Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: Source/core/dom/DOMSettableTokenList.h

Issue 130403008: Update DOMTokenList::value() to return a const reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/DOMTokenList.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 virtual void ref() OVERRIDE { RefCounted<DOMSettableTokenList>::ref(); } 46 virtual void ref() OVERRIDE { RefCounted<DOMSettableTokenList>::ref(); }
47 virtual void deref() OVERRIDE { RefCounted<DOMSettableTokenList>::deref(); } 47 virtual void deref() OVERRIDE { RefCounted<DOMSettableTokenList>::deref(); }
48 48
49 virtual unsigned length() const OVERRIDE { return m_tokens.size(); } 49 virtual unsigned length() const OVERRIDE { return m_tokens.size(); }
50 virtual const AtomicString item(unsigned index) const OVERRIDE; 50 virtual const AtomicString item(unsigned index) const OVERRIDE;
51 51
52 virtual void add(const Vector<String>&, ExceptionState&) OVERRIDE; 52 virtual void add(const Vector<String>&, ExceptionState&) OVERRIDE;
53 virtual void remove(const Vector<String>&, ExceptionState&) OVERRIDE; 53 virtual void remove(const Vector<String>&, ExceptionState&) OVERRIDE;
54 54
55 virtual AtomicString value() const OVERRIDE { return m_value; } 55 virtual const AtomicString& value() const OVERRIDE { return m_value; }
56 virtual void setValue(const AtomicString&) OVERRIDE; 56 virtual void setValue(const AtomicString&) OVERRIDE;
57 57
58 const SpaceSplitString& tokens() const { return m_tokens; } 58 const SpaceSplitString& tokens() const { return m_tokens; }
59 59
60 protected: 60 protected:
61 DOMSettableTokenList(); 61 DOMSettableTokenList();
62 62
63 private: 63 private:
64 virtual void addInternal(const AtomicString&) OVERRIDE; 64 virtual void addInternal(const AtomicString&) OVERRIDE;
65 virtual bool containsInternal(const AtomicString&) const OVERRIDE; 65 virtual bool containsInternal(const AtomicString&) const OVERRIDE;
66 virtual void removeInternal(const AtomicString&) OVERRIDE; 66 virtual void removeInternal(const AtomicString&) OVERRIDE;
67 67
68 AtomicString m_value; 68 AtomicString m_value;
69 SpaceSplitString m_tokens; 69 SpaceSplitString m_tokens;
70 }; 70 };
71 71
72 } // namespace WebCore 72 } // namespace WebCore
73 73
74 #endif // DOMSettableTokenList_h 74 #endif // DOMSettableTokenList_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/DOMTokenList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698