Remove LDAP support from NSS.

Remove LDAP support from NSS.

R=rsleevi@chromium.org
BUG=289680
TEST=none

[wtc, 2014-01-11 04:14:04]

Ryan: please review patch set 2. If it looks good, I will generate a patch file
and update README.chromium. Thanks.

Patch set 1 is the original patch that I attached to the upstream NSS bug
report. Given Bob's and your interest in preserving LDAP support, I decided to
add a build option NSS_PKIX_NO_LDAP to disable the code.

[Ryan Sleevi, 2014-01-11 04:24:02]

On 2014/01/11 04:14:04, wtc wrote:
> Ryan: please review patch set 2. If it looks good, I will generate a patch
file
> and update README.chromium. Thanks.
> 
> Patch set 1 is the original patch that I attached to the upstream NSS bug
> report. Given Bob's and your interest in preserving LDAP support, I decided to
> add a build option NSS_PKIX_NO_LDAP to disable the code.

To be clear, I'm not terribly interested in preserving LDAP support other than
knowing it was in Bob's interests ;)

Your description of patchset 2 says "rather than deleting code" - but you still
end up deleting code. Is it easier to just leave that code as is within the tree
- just not compiled? That should make merges easier, right?

This LGTM, although I have not poked all of the threads to make sure there isn't
*more* code to remove. Certainly, this gets to the core pieces, and the use of
the #ifdef will provide compile errors if we failed to do things correctly.

[wtc, 2014-01-13 23:34:27]

Please review patch set 3. Thanks.

I originally removed the 10 LDAP source files because I wanted to reduce source
tree checkout time. But the thought of leaving those files in the source tree
also crossed my mind. And since you also asked about it, I added them back.

Also, I should have clarified that the purpose of including patch set 1 was to
help me verify patch set 2 conditionally disables the same code that I tried to
remove.

When I wrote patch set 1, I was careful in removing everything that could be
removed. It is possible that I missed some functions that were only used by the
code I removed, even though I also tried to remove them.

[Ryan Sleevi, 2014-01-13 23:56:49]

lgtm

[commit-bot: I haz the power, 2014-01-14 00:01:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/130403004/260001

[commit-bot: I haz the power, 2014-01-14 00:01:42]

Change committed as 244613