chrome/browser/android/bottombar/contextualsearch/contextual_search_panel.cc - Issue 1304013002: Move functionality for ContentViewCore to ContextualSearchPanel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/bottombar/contextualsearch/contextual_search_panel.cc

Issue 1304013002: Move functionality for ContentViewCore to ContextualSearchPanel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple-move-cvc-to-panel

Patch Set: Rebase & revert ContextualSearchRequest Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java ('K') | « chrome/browser/android/bottombar/contextualsearch/contextual_search_panel.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/bottombar/contextualsearch/contextual_search_panel.cc

diff --git a/chrome/browser/android/bottombar/contextualsearch/contextual_search_panel.cc b/chrome/browser/android/bottombar/contextualsearch/contextual_search_panel.cc

index 41235e3ba4f94d1a08d6c60e7e81dca35d9d4291..7e169319d521f35e4379eef072d43b5e25f97870 100644

--- a/chrome/browser/android/bottombar/contextualsearch/contextual_search_panel.cc

+++ b/chrome/browser/android/bottombar/contextualsearch/contextual_search_panel.cc

@@ -117,12 +117,6 @@ void ContextualSearchPanel::DestroyWebContents(JNIEnv* env, jobject jobj) {

web_contents_delegate_.reset();

}

-void ContextualSearchPanel::ReleaseWebContents(JNIEnv* env, jobject jboj) {

- DCHECK(web_contents_.get());

- web_contents_delegate_.reset();

- ignore_result(web_contents_.release());

void ContextualSearchPanel::SetInterceptNavigationDelegate(

JNIEnv* env,

jobject obj,