Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2487)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java

Issue 1304013002: Move functionality for ContentViewCore to ContextualSearchPanel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple-move-cvc-to-panel
Patch Set: Rebase & revert ContextualSearchRequest Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
index d0c8932667a7db4af11542b3cddbbc2c6fa9d428..85cef8dfd511f64ff0bb90c9be0386c5816b22d7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
@@ -54,11 +54,6 @@ public interface ContextualSearchManagementDelegate {
void promoteToTab();
/**
- * Resets the Search Content View scroll position.
- */
- void resetSearchContentViewScroll();
-
- /**
* Gets the Search Content View's vertical scroll position. If the Search Content View
* is not available it returns -1.
* @return The Search Content View scroll position.
@@ -71,7 +66,7 @@ public interface ContextualSearchManagementDelegate {
* it invisible, only visible.
* @param isVisible True to make it visible.
*/
- void setSearchContentViewVisibility(boolean isVisible);
+ //void setSearchContentViewVisibility(boolean isVisible);
/**
* Sets the delegate responsible for manipulating the ContextualSearchLayout.
@@ -123,4 +118,37 @@ public interface ContextualSearchManagementDelegate {
* @return Whether the current activity contains a {@link CustomTab}.
*/
boolean isCustomTab();
+
+ /**
+ * @return The ContentViewCore of the base page that contextual search is showing on.
+ */
+ ContentViewCore getBaseContentView();
+
+ /**
+ * This method is called when the panel's ContentViewCore is created.
+ * @param contentView The created ContentViewCore.
+ */
+ void onContentViewCreated(ContentViewCore contentView);
+
+ /**
+ * This method is called when the panel's ContentViewCore is destroyed.
+ */
+ void onContentViewDestroyed();
+
+ /**
+ * This is called on navigation of the contextual search pane This is called on navigation
+ * of the contextual search panel.
+ */
+ void onContextualSearchRequestNavigation(boolean isFailure);
David Trainor- moved to gerrit 2015/08/28 22:02:18 @param
mdjones 2015/08/28 23:51:58 Done.
+
+ /**
+ * This is called when the search panel is shown or is hidden.
+ * @param isVisible True if the panel is now visible.
+ */
+ void onContentViewVisibilityChanged(boolean isVisible);
David Trainor- moved to gerrit 2015/08/28 22:02:18 @param
mdjones 2015/08/28 23:51:58 Already there
+
+ /**
+ * This is called when the panel has loaded search results.
+ */
+ void onSearchResultsLoaded();
}

Powered by Google App Engine
This is Rietveld 408576698