chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEventFilterTest.java - Issue 1304013002: Move functionality for ContentViewCore to ContextualSearchPanel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEventFilterTest.java

Issue 1304013002: Move functionality for ContentViewCore to ContextualSearchPanel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple-move-cvc-to-panel

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/DEPS ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFakeServer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEventFilterTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEventFilterTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEventFilterTest.java

index ab6f0e94ed41918c94ca5928ccfb01c6ec11c642..d9f48e119ea1c0da202d9739de48fdf000c5d49d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEventFilterTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEventFilterTest.java

@@ -19,10 +19,6 @@ import org.chromium.chrome.browser.compositor.layouts.LayoutUpdateHost;

import org.chromium.chrome.browser.compositor.layouts.eventfilter.ContextualSearchEventFilter;

import org.chromium.chrome.browser.compositor.layouts.eventfilter.EventFilterHost;

import org.chromium.chrome.browser.compositor.layouts.eventfilter.GestureHandler;

-import org.chromium.components.navigation_interception.InterceptNavigationDelegate;

-import org.chromium.components.web_contents_delegate_android.WebContentsDelegateAndroid;

-import org.chromium.content.browser.ContentViewCore;

-import org.chromium.content_public.browser.WebContents;

/**

* Class responsible for testing the ContextualSearchEventFilter.

@@ -142,26 +138,17 @@ public class ContextualSearchEventFilterTest extends InstrumentationTestCase

return 0;

}

- // TODO(mdjones): Most of these should be removed in when refactor is complete.

@Override

public void destroy() {}

@Override

- public void removeLastHistoryEntry(String historyUrl, long urlTimeMs) {}

- @Override

- public void setWebContents(ContentViewCore contentViewCore,

- WebContentsDelegateAndroid delegate) {}

+ public void createNewContentView() {}

@Override

- public void destroyWebContents() {}

+ public void destroyContentView() {}

@Override

- public void releaseWebContents() {}

- @Override

- public void setInterceptNavigationDelegate(InterceptNavigationDelegate delegate,

- WebContents webContents) {}

+ public void removeLastHistoryEntry(String historyUrl, long urlTimeMs) {}

}

// --------------------------------------------------------------------------------------------