Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java

Issue 1304013002: Move functionality for ContentViewCore to ContextualSearchPanel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple-move-cvc-to-panel
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java
index 444c5160df41b9cbb8569a3990d8386700a068f8..598b489f36325121818c05d50bf658f733c914b8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java
@@ -38,12 +38,6 @@ public interface ContextualSearchNetworkCommunicator {
String searchTerm, String displayText, String alternateTerm, boolean doPreventPreload,
int selectionStartAdjust, int selectionEndAdjust);
- /**
- * Loads a URL in the search content view.
- * @param url the URL of the page to load.
- */
- void loadUrl(String url);
-
// --------------------------------------------------------------------------------------------
// These are non-network actions that need to be stubbed out for testing.
// --------------------------------------------------------------------------------------------
@@ -55,23 +49,4 @@ public interface ContextualSearchNetworkCommunicator {
* @return The URL of the base page (needed for testing purposes).
*/
@Nullable URL getBasePageUrl();
-
- /**
- * Handles the WebContentsObserver#didNavigateMainFrame callback.
- * @param url The URL of the navigation.
- * @param httpResultCode The HTTP result code of the navigation.
- */
- void handleDidNavigateMainFrame(String url, int httpResultCode);
-
- /**
- * Creates and sets up a new Search Panel's {@code ContentViewCore}. If there's an existing
- * {@code ContentViewCore} being used, it will be destroyed first. This should be called as
- * late as possible to avoid unnecessarily consuming memory.
- */
- void createNewSearchContentView();
-
- /**
- * Destroys the Search Panel's {@code ContentViewCore}.
- */
- void destroySearchContentView();
}

Powered by Google App Engine
This is Rietveld 408576698