Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java

Issue 1304013002: Move functionality for ContentViewCore to ContextualSearchPanel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple-move-cvc-to-panel
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
index d0c8932667a7db4af11542b3cddbbc2c6fa9d428..4ef5658b6ce2877e8d5415f74d635deaa2a0e34a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
@@ -7,7 +7,9 @@ package org.chromium.chrome.browser.contextualsearch;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel.StateChangeReason;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanelDelegate;
import org.chromium.chrome.browser.customtabs.CustomTab;
+import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler;
import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.components.navigation_interception.NavigationParams;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content_public.common.TopControlsState;
@@ -54,11 +56,6 @@ public interface ContextualSearchManagementDelegate {
void promoteToTab();
/**
- * Resets the Search Content View scroll position.
- */
- void resetSearchContentViewScroll();
-
- /**
* Gets the Search Content View's vertical scroll position. If the Search Content View
* is not available it returns -1.
* @return The Search Content View scroll position.
@@ -66,14 +63,6 @@ public interface ContextualSearchManagementDelegate {
float getSearchContentViewVerticalScroll();
/**
- * Sets the visibility of the Search Content View.
- * TODO(pedrosimonetti): Revisit this API. Consumers should not be allowed to make
- * it invisible, only visible.
- * @param isVisible True to make it visible.
- */
- void setSearchContentViewVisibility(boolean isVisible);
-
- /**
* Sets the delegate responsible for manipulating the ContextualSearchLayout.
* @param delegate The ContextualSearchLayoutDelegate.
*/
@@ -123,4 +112,60 @@ public interface ContextualSearchManagementDelegate {
* @return Whether the current activity contains a {@link CustomTab}.
*/
boolean isCustomTab();
+
+ /**
+ * This method is called when the panel's ContentViewCore is created.
+ * @param contentView The created ContentViewCore.
+ */
+ void onContentViewCreated(ContentViewCore contentView);
+
+ /**
+ * This method is called when the panel's ContentViewCore is destroyed.
+ */
+ void onContentViewDestroyed();
+
+ /**
+ * This is called on navigation of the contextual search pane This is called on navigation
+ * of the contextual search panel.
+ * @param isFailure If the request resulted in an error page.
+ */
+ void onContextualSearchRequestNavigation(boolean isFailure);
+
+ /**
+ * This is called when the search panel is shown or is hidden.
+ * @param isVisible True if the panel is now visible.
+ */
+ void onContentViewVisibilityChanged(boolean isVisible);
+
+ /**
+ * This is called when the panel has loaded search results.
+ */
+ void onSearchResultsLoaded();
+
+ /**
+ * Called when an external navigation occurs.
+ * @param url The URL being navigated to.
+ */
+ void onExternalNavigation(String url);
+
+ /**
+ * Handles the WebContentsObserver#didNavigateMainFrame callback.
+ * @param url The URL of the navigation.
+ * @param httpResultCode The HTTP result code of the navigation.
+ */
+ void handleDidNavigateMainFrame(String url, int httpResultCode);
+
+ /**
+ * Called when the WebContents for the panel starts loading.
+ */
+ void onStartedLoading();
+
+ /**
+ * Determine if a particular navigation should be ignored.
+ * @param externalNavHandler External navigation handler for the activity the panel is in.
+ * @param navigationParams The navigation params for the current navigation.
+ * @return True if the navigation should be ignored.
+ */
+ boolean shouldInterceptNavigation(ExternalNavigationHandler externalNavHandler,
+ NavigationParams navigationParams);
}

Powered by Google App Engine
This is Rietveld 408576698