Issue 13040003: Fix ToolsSanityTest.DataRace under TSan v1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13040003: Fix ToolsSanityTest.DataRace under TSan v1. (Closed)

Created:
7 years, 9 months ago by Alexander Potapenko

Modified:
7 years, 9 months ago

Reviewers:
Lei Zhang, darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix ToolsSanityTest.DataRace under TSan v1 by allocating the shared variable on the heap instead of stack. For some reason the test interferes with others and the race on the stack variable gets ignored. BUG=223016 TBR=thestig,darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190002

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	base/tools_sanity_unittest.cc	View	1	1 chunk	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

Committed patchset #4 manually as r190002 (presubmit successful).

7 years, 9 months ago (2013-03-23 11:28:22 UTC) #2

Lei Zhang

7 years, 9 months ago (2013-03-23 15:33:14 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/13040003/diff/8002/base/tools_sanity_unittest.cc
File base/tools_sanity_unittest.cc (right):

https://codereview.chromium.org/13040003/diff/8002/base/tools_sanity_unittest...
base/tools_sanity_unittest.cc:250: bool *shared = new bool(false);
small nit: bool*

Expand Messages | Collapse Messages