Chromium Code Reviews Chromium Code Reviews
Issue
1303993007:
Floats' margins do not collapse with page or column boundaries. (Closed)
DescriptionFloats' margins do not collapse with page or column boundaries.
When we push a float to the next page or column, push its top margin as well,
and do so consistently. In some cases we lost the margin, in some other cases
we got a double margin, and in yet some other cases we actually got it right.
There was code that asserted (in a comment) that having a pagination strut and
being unsplittable for pagination were mutually exclusive, but that's wrong. If
the first child (block / line) of a float doesn't fit in the current page or
column, we'll set a strut on the float. At the same time, the float may very
well be unsplittable for pagination. So, first pushing to the next page or
column because it's unsplittable, and THEN adding the strut will effectively
result in adding the pagination strut twice. This would be a problem both with
and without a top margin on the float.
R=jchaffraix@chromium.org,leviw@chromium.org
Committed: https://crrev.com/f30679485a3cf6914a2334acb5b0de371aa7ceae
git-svn-id: svn://svn.chromium.org/blink/trunk@202212 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Patch Set 1 #Messages
Total messages: 10 (3 generated)
|
