Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: Source/modules/indexeddb/IDBDatabase.cpp

Issue 1303983002: IndexedDB: Treat count of 0 as unbounded for getAll() methods (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/indexeddb/IDBDatabase.h ('k') | Source/modules/indexeddb/IDBIndex.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 const char IDBDatabase::noValueErrorMessage[] = "The cursor is being iterated or has iterated past its end."; 60 const char IDBDatabase::noValueErrorMessage[] = "The cursor is being iterated or has iterated past its end.";
61 const char IDBDatabase::notValidKeyErrorMessage[] = "The parameter is not a vali d key."; 61 const char IDBDatabase::notValidKeyErrorMessage[] = "The parameter is not a vali d key.";
62 const char IDBDatabase::notVersionChangeTransactionErrorMessage[] = "The databas e is not running a version change transaction."; 62 const char IDBDatabase::notVersionChangeTransactionErrorMessage[] = "The databas e is not running a version change transaction.";
63 const char IDBDatabase::objectStoreDeletedErrorMessage[] = "The object store has been deleted."; 63 const char IDBDatabase::objectStoreDeletedErrorMessage[] = "The object store has been deleted.";
64 const char IDBDatabase::requestNotFinishedErrorMessage[] = "The request has not finished."; 64 const char IDBDatabase::requestNotFinishedErrorMessage[] = "The request has not finished.";
65 const char IDBDatabase::sourceDeletedErrorMessage[] = "The cursor's source or ef fective object store has been deleted."; 65 const char IDBDatabase::sourceDeletedErrorMessage[] = "The cursor's source or ef fective object store has been deleted.";
66 const char IDBDatabase::transactionInactiveErrorMessage[] = "The transaction is not active."; 66 const char IDBDatabase::transactionInactiveErrorMessage[] = "The transaction is not active.";
67 const char IDBDatabase::transactionFinishedErrorMessage[] = "The transaction has finished."; 67 const char IDBDatabase::transactionFinishedErrorMessage[] = "The transaction has finished.";
68 const char IDBDatabase::transactionReadOnlyErrorMessage[] = "The transaction is read-only."; 68 const char IDBDatabase::transactionReadOnlyErrorMessage[] = "The transaction is read-only.";
69 const char IDBDatabase::databaseClosedErrorMessage[] = "The database connection is closed."; 69 const char IDBDatabase::databaseClosedErrorMessage[] = "The database connection is closed.";
70 const char IDBDatabase::notValidMaxCountErrorMessage[] = "The maxCount provided must not be 0.";
71 70
72 IDBDatabase* IDBDatabase::create(ExecutionContext* context, PassOwnPtr<WebIDBDat abase> database, IDBDatabaseCallbacks* callbacks) 71 IDBDatabase* IDBDatabase::create(ExecutionContext* context, PassOwnPtr<WebIDBDat abase> database, IDBDatabaseCallbacks* callbacks)
73 { 72 {
74 IDBDatabase* idbDatabase = new IDBDatabase(context, database, callbacks); 73 IDBDatabase* idbDatabase = new IDBDatabase(context, database, callbacks);
75 idbDatabase->suspendIfNeeded(); 74 idbDatabase->suspendIfNeeded();
76 return idbDatabase; 75 return idbDatabase;
77 } 76 }
78 77
79 IDBDatabase::IDBDatabase(ExecutionContext* context, PassOwnPtr<WebIDBDatabase> b ackend, IDBDatabaseCallbacks* callbacks) 78 IDBDatabase::IDBDatabase(ExecutionContext* context, PassOwnPtr<WebIDBDatabase> b ackend, IDBDatabaseCallbacks* callbacks)
80 : ActiveDOMObject(context) 79 : ActiveDOMObject(context)
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 { 450 {
452 return EventTargetNames::IDBDatabase; 451 return EventTargetNames::IDBDatabase;
453 } 452 }
454 453
455 ExecutionContext* IDBDatabase::executionContext() const 454 ExecutionContext* IDBDatabase::executionContext() const
456 { 455 {
457 return ActiveDOMObject::executionContext(); 456 return ActiveDOMObject::executionContext();
458 } 457 }
459 458
460 } // namespace blink 459 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/indexeddb/IDBDatabase.h ('k') | Source/modules/indexeddb/IDBIndex.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698