IndexedDB: Treat count of 0 as unbounded for getAll() methods

Source/modules/indexeddb/IDBObjectStore.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 108 matching lines @@
 }
 
 IDBRequest* IDBObjectStore::getAll(ScriptState* scriptState, const ScriptValue& keyRange, ExceptionState& exceptionState)
 {
     return getAll(scriptState, keyRange, std::numeric_limits<uint32_t>::max(), exceptionState);
 }
 
 IDBRequest* IDBObjectStore::getAll(ScriptState* scriptState, const ScriptValue& keyRange, unsigned long maxCount, ExceptionState& exceptionState)
 {
     IDB_TRACE("IDBObjectStore::getAll");
-    if (!maxCount) {
-        exceptionState.throwTypeError(IDBDatabase::notValidMaxCountErrorMessage);

[cmumford, 2015/08/21 17:32:40]

Since you're deleting all references to notValidMaxCountErrorMessage you can
remove it from IDBDatabase.*

[jsbell, 2015/08/21 17:48:32]

Done.

-        return nullptr;
-    }
+    if (!maxCount)
+        maxCount = std::numeric_limits<uint32_t>::max();
+
     if (isDeleted()) {
         exceptionState.throwDOMException(InvalidStateError, IDBDatabase::objectStoreDeletedErrorMessage);
         return nullptr;
     }
     if (m_transaction->isFinished() || m_transaction->isFinishing()) {
         exceptionState.throwDOMException(TransactionInactiveError, IDBDatabase::transactionFinishedErrorMessage);
         return nullptr;
     }
     if (!m_transaction->isActive()) {
         exceptionState.throwDOMException(TransactionInactiveError, IDBDatabase::transactionInactiveErrorMessage);
@@ skipping 13 matching lines @@
 }
 
 IDBRequest* IDBObjectStore::getAllKeys(ScriptState* scriptState, const ScriptValue& keyRange, ExceptionState& exceptionState)
 {
     return getAllKeys(scriptState, keyRange, std::numeric_limits<uint32_t>::max(), exceptionState);
 }
 
 IDBRequest* IDBObjectStore::getAllKeys(ScriptState* scriptState, const ScriptValue& keyRange, unsigned long maxCount, ExceptionState& exceptionState)
 {
     IDB_TRACE("IDBObjectStore::getAll");
-    if (!maxCount) {
-        exceptionState.throwTypeError(IDBDatabase::notValidMaxCountErrorMessage);
-        return 0;
-    }
+    if (!maxCount)
+        maxCount = std::numeric_limits<uint32_t>::max();
+
     if (isDeleted()) {
         exceptionState.throwDOMException(InvalidStateError, IDBDatabase::objectStoreDeletedErrorMessage);
         return 0;
     }
     if (m_transaction->isFinished() || m_transaction->isFinishing()) {
         exceptionState.throwDOMException(TransactionInactiveError, IDBDatabase::transactionFinishedErrorMessage);
         return 0;
     }
     if (!m_transaction->isActive()) {
         exceptionState.throwDOMException(TransactionInactiveError, IDBDatabase::transactionInactiveErrorMessage);
@@ skipping 570 matching lines @@
     }
     return IDBIndexMetadata::InvalidId;
 }
 
 WebIDBDatabase* IDBObjectStore::backendDB() const
 {
     return m_transaction->backendDB();
 }
 
 } // namespace blink