Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

Issue 1303973009: [DO NOT COMMIT] Re-use the dafsa code for s-w-r histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to fix patch errors on try bots. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h
similarity index 54%
copy from chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
copy to chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h
index 58eebca22a8fb8b653b330b4a782f9ca3ff8dbc6..100978a38ceaa8e004ad602cb053ce57bcc383d1 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h
@@ -2,16 +2,22 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OBSERVER_H_
-#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OBSERVER_H_
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRICS_OBSERVER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRICS_OBSERVER_H_
#include "base/macros.h"
#include "components/page_load_metrics/browser/page_load_metrics_observer.h"
-class FromGWSPageLoadMetricsObserver
+namespace content {
+class NavigationHandle;
+}
+
+namespace chrome {
+
+class StaleWhileRevalidateMetricsObserver
: public page_load_metrics::PageLoadMetricsObserver {
public:
- explicit FromGWSPageLoadMetricsObserver(
+ explicit StaleWhileRevalidateMetricsObserver(
page_load_metrics::PageLoadMetricsObservable* metrics);
// page_load_metrics::PageLoadMetricsObserver implementation:
void OnCommit(content::NavigationHandle* navigation_handle) override;
@@ -20,16 +26,15 @@ class FromGWSPageLoadMetricsObserver
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
void OnPageLoadMetricsGoingAway() override;
- protected:
- // Called in tests.
- void SetCommittedURLAndReferrer(const GURL& url,
- const content::Referrer& referrer);
-
private:
- bool navigation_from_gws_;
+ // True if the committed URL is one of the domains of interest to the
+ // stale-while-revalidate experiment.
+ bool is_interesting_domain_;
page_load_metrics::PageLoadMetricsObservable* const metrics_;
- DISALLOW_COPY_AND_ASSIGN(FromGWSPageLoadMetricsObserver);
+ DISALLOW_COPY_AND_ASSIGN(StaleWhileRevalidateMetricsObserver);
};
-#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OBSERVER_H_
+} // namespace chrome
+
+#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRICS_OBSERVER_H_
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc » ('j') | net/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698