OLD | NEW |
---|---|
1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h" | 5 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h" |
6 | 6 |
7 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_ observer.h" | 7 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_ observer.h" |
8 #include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metr ics_observer.h" | |
8 #include "components/page_load_metrics/browser/metrics_web_contents_observer.h" | 9 #include "components/page_load_metrics/browser/metrics_web_contents_observer.h" |
9 #include "content/public/browser/web_contents.h" | 10 #include "content/public/browser/web_contents.h" |
10 | 11 |
11 namespace { | 12 namespace { |
12 | 13 |
13 void RegisterPageLoadMetricsObservers( | 14 void RegisterPageLoadMetricsObservers( |
14 page_load_metrics::PageLoadMetricsObservable* metrics) { | 15 page_load_metrics::PageLoadMetricsObservable* metrics) { |
15 // Attach observers scoped to the web contents here. | 16 // Attach observers scoped to the web contents here. |
16 | 17 |
17 // This is a self-destruct class, and will delete itself when triggered by | 18 // This is a self-destruct class, and will delete itself when triggered by |
18 // OnPageLoadMetricsGoingAway. | 19 // OnPageLoadMetricsGoingAway. |
19 metrics->AddObserver(new FromGWSPageLoadMetricsObserver(metrics)); | 20 metrics->AddObserver(new FromGWSPageLoadMetricsObserver(metrics)); |
21 // StaleWhileRevalidateMetricsObserver also deletes itself from | |
22 // OnPageLoadMetricsGoingAway. | |
tyoshino (SeeGerritForStatus)
2015/11/04 08:34:07
merge with the comments at L18-19?
Adam Rice
2015/11/05 05:30:39
The FromGWS metrics are permanent, but the StaleWh
tyoshino (SeeGerritForStatus)
2015/11/05 09:00:02
Ah, got it!
| |
23 metrics->AddObserver(new StaleWhileRevalidateMetricsObserver(metrics)); | |
20 } | 24 } |
21 | 25 |
22 } // namespace | 26 } // namespace |
23 | 27 |
24 namespace chrome { | 28 namespace chrome { |
25 | 29 |
26 void InitializePageLoadMetricsForWebContents( | 30 void InitializePageLoadMetricsForWebContents( |
27 content::WebContents* web_contents) { | 31 content::WebContents* web_contents) { |
28 RegisterPageLoadMetricsObservers( | 32 RegisterPageLoadMetricsObservers( |
29 page_load_metrics::MetricsWebContentsObserver::CreateForWebContents( | 33 page_load_metrics::MetricsWebContentsObserver::CreateForWebContents( |
30 web_contents)); | 34 web_contents)); |
31 } | 35 } |
32 | 36 |
33 } // namespace chrome | 37 } // namespace chrome |
OLD | NEW |