Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1303953003: Expand the interface to WebURLLoaderTestDelegate. (Closed)

Created:
5 years, 4 months ago by esprehn
Modified:
5 years, 4 months ago
Reviewers:
pdr., dcheng
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expand the interface to WebURLLoaderTestDelegate. To implement FOUC tests we need to be able to control both the didReceiveData and the didFinishLoading callbacks to have precise control over when resources finish loading. This patch expands the interface of WebURLLoaderTestDelegate to delegate all the steps called in WebURLLoaderMock::ServeAsynchronousRequest. It also provides a default implementation of each one so tests don't need to add each proxy method. It also allows this patch to avoid being multiple steps to handle the Chromium changes. The next patch in Chromium will update ServeAsynchronousRequest to use the new methods. BUG=521692 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201003

Patch Set 1 #

Patch Set 2 : Add missing files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -10 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A Source/platform/exported/WebURLLoaderTestDelegate.cpp View 1 1 chunk +43 lines, -0 lines 0 comments Download
A public/platform/WebURLLoaderTestDelegate.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
M public/platform/WebUnitTestSupport.h View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 30 (14 generated)
esprehn
5 years, 4 months ago (2015-08-21 05:33:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303953003/1
5 years, 4 months ago (2015-08-21 05:34:00 UTC) #4
pdr.
Did you forget to add a file?
5 years, 4 months ago (2015-08-21 05:35:19 UTC) #6
esprehn
On 2015/08/21 at 05:35:19, pdr wrote: > Did you forget to add a file? Yeah ...
5 years, 4 months ago (2015-08-21 05:37:26 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303953003/20001
5 years, 4 months ago (2015-08-21 05:37:51 UTC) #9
pdr.
LGTM
5 years, 4 months ago (2015-08-21 05:41:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303953003/20001
5 years, 4 months ago (2015-08-21 05:41:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/101708) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 4 months ago (2015-08-21 06:39:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303953003/20001
5 years, 4 months ago (2015-08-21 06:56:20 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/101730)
5 years, 4 months ago (2015-08-21 08:56:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303953003/20001
5 years, 4 months ago (2015-08-21 09:07:45 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/96663)
5 years, 4 months ago (2015-08-21 10:35:31 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303953003/20001
5 years, 4 months ago (2015-08-21 15:40:43 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/101898)
5 years, 4 months ago (2015-08-21 17:28:17 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303953003/20001
5 years, 4 months ago (2015-08-21 18:11:48 UTC) #29
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 19:03:46 UTC) #30
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201003

Powered by Google App Engine
This is Rietveld 408576698