Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1303943002: Rebaseline fast/ tests on Yosemite (Closed)

Created:
5 years, 4 months ago by leviw_travelin_and_unemployed
Modified:
5 years, 4 months ago
Reviewers:
joelo, eae, ojan
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rebaseline fast/ tests on Yosemite Also converting fast/forms/button-generated-content.html to use the Ahem font, which eliminates a sub-pixel font-related issue that was causing the ref test to fail on Yosemite. BUG=509025 R=eae,joelo,ojan Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200937

Patch Set 1 #

Patch Set 2 : ToTed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -163 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +161 lines, -163 lines 0 comments Download
M LayoutTests/fast/forms/button-generated-content.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/button-generated-content-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
leviw_travelin_and_unemployed
5 years, 4 months ago (2015-08-20 21:37:54 UTC) #1
eae
LGTM PDR=true
5 years, 4 months ago (2015-08-20 21:40:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303943002/1
5 years, 4 months ago (2015-08-20 21:40:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/59410) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-20 21:42:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303943002/20001
5 years, 4 months ago (2015-08-20 21:49:39 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 22:55:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200937

Powered by Google App Engine
This is Rietveld 408576698