Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 130393002: Make inline install for disabled items just re-enable (Closed)

Created:
6 years, 11 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 11 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Make inline install for disabled items just re-enable them Based on initial patch by rdevlin.cronin@chromium.org BUG=308355 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243958

Patch Set 1 #

Patch Set 2 : Moved short-circuit code from BeginInstall to InstallUIProceed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/browser/extensions/webstore_standalone_installer.cc View 1 3 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
asargent_no_longer_on_chrome
6 years, 11 months ago (2014-01-09 16:56:30 UTC) #1
Devlin
LGTM. We'll need to make more improvements later, but good for the moment.
6 years, 11 months ago (2014-01-09 17:50:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/130393002/20001
6 years, 11 months ago (2014-01-09 18:06:53 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 19:45:41 UTC) #4
Message was sent while issue was closed. 
Change committed as 243958

Powered by Google App Engine
This is Rietveld 408576698