Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 1303923002: Remove new space allocation in optimizing compiler, use Symbols::FromConcat where appropriate (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Optimize Symbols::FromConcat Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/parser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc
index fd4d9e2868d3477577bbb30e8071dc237ae64564..fc7dd589bb226aae8adb6eeae1052522fa021ea5 100644
--- a/runtime/vm/class_finalizer.cc
+++ b/runtime/vm/class_finalizer.cc
@@ -1642,8 +1642,7 @@ void ClassFinalizer::CloneMixinAppTypeParameters(const Class& mixin_app_class) {
for (intptr_t i = 0; i < num_super_type_params; i++) {
param ^= super_type_params.TypeAt(i);
param_name = param.name();
- param_name = String::Concat(param_name, Symbols::Backtick());
- param_name = Symbols::New(param_name);
+ param_name = Symbols::FromConcat(param_name, Symbols::Backtick());
cloned_param = TypeParameter::New(mixin_app_class,
cloned_index,
param_name,
@@ -2104,8 +2103,7 @@ void ClassFinalizer::CreateForwardingConstructors(
const String& ctor_name = String::Handle(func.name());
String& clone_name = String::Handle(
String::SubString(ctor_name, super_name.Length()));
- clone_name = String::Concat(mixin_name, clone_name);
- clone_name = Symbols::New(clone_name);
+ clone_name = Symbols::FromConcat(mixin_name, clone_name);
if (FLAG_trace_class_finalization) {
ISL_Print("Cloning constructor '%s' as '%s'\n",
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698