Issue 1303913003: Fixes #287 and other failures statically checking SDK tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1303913003: Fixes #287 and other failures statically checking SDK tests (Closed)

Created:
5 years, 4 months ago by vsm

Modified:
5 years, 4 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org, Brian Wilkerson

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fixes #287 and other failures statically checking SDK tests This adds some defensiveness to override checking and other checks. It fixes all known crashers running dartanalyzer in strong mode on language, co19, etc. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a619369252a8e0b322194bdd629c942bfeab4a36

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -10 lines)			Patch
M	lib/src/checker/checker.dart	View	1	5 chunks	+23 lines, -7 lines	0 comments	Download
M	lib/src/checker/resolver.dart	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	lib/src/checker/rules.dart	View		4 chunks	+11 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

vsm

5 years, 4 months ago (2015-08-21 20:15:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a619369252a8e0b322194bdd629c942bfeab4a36 (presubmit successful).