Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1303873003: fix cubic clip in y (Closed)

Created:
5 years, 4 months ago by caryclark
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix cubic clip in y Follow on to https://codereview.chromium.org/1299243002/ Clip using a geometric solution if the algebraic solution fails in Y as well as in X. If the root finder discovers real roots that are sufficiently far apart, the root in the range of 0..1 can contain so much error that it is computed to be slightly smaller than 0 or larger than 1. In this case, binary search the mono curve for the actual answer. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/05424f77fa8812b6c9e3a21def954e2c8971886a

Patch Set 1 #

Patch Set 2 : fix override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -57 lines) Patch
M gm/cubicpaths.cpp View 1 3 chunks +22 lines, -3 lines 0 comments Download
M src/core/SkEdgeClipper.cpp View 2 chunks +51 lines, -54 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303873003/1
5 years, 4 months ago (2015-08-20 17:18:26 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-20 17:18:27 UTC) #3
reed1
lgtm
5 years, 4 months ago (2015-08-20 17:34:44 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 17:35:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/05424f77fa8812b6c9e3a21def954e2c8971886a

Powered by Google App Engine
This is Rietveld 408576698