Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Issue 1303843003: Don't allocate AstTyper with the zone allocator. (Closed)

Created:
5 years, 4 months ago by bradn
Modified:
5 years, 4 months ago
Reviewers:
titzer, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't allocate AstTyper with the zone allocator. While the class Type objects the AstTyper generates should be allocated to zone memory, there's no particular reason the typer object itself needs to be. BUG=None TEST=None R=rossberg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/233599fa70818f1ef6ff2860f7762ab29f32653f Cr-Commit-Position: refs/heads/master@{#30313}

Patch Set 1 #

Patch Set 2 : revised #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M src/compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/typing.h View 1 1 chunk +2 lines, -7 lines 0 comments Download
M src/typing.cc View 1 2 chunks +7 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
bradn
5 years, 4 months ago (2015-08-20 21:35:56 UTC) #1
rossberg
lgtm
5 years, 4 months ago (2015-08-21 09:40:22 UTC) #2
titzer
On 2015/08/21 09:40:22, rossberg wrote: > lgtm lgtm as well
5 years, 4 months ago (2015-08-21 10:27:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303843003/20001
5 years, 4 months ago (2015-08-21 18:14:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-21 18:15:38 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 18:15:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/233599fa70818f1ef6ff2860f7762ab29f32653f
Cr-Commit-Position: refs/heads/master@{#30313}

Powered by Google App Engine
This is Rietveld 408576698