Migrate from fullPath to Entry in the mosaic view.

chrome/browser/resources/file_manager/foreground/js/photo/mosaic_mode.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @param {Element} container Content container.
  * @param {cr.ui.ArrayDataModel} dataModel Data model.
  * @param {cr.ui.ListSelectionModel} selectionModel Selection model.
  * @param {MetadataCache} metadataCache Metadata cache.
+ * @param {VolumeManagerWrapper} volumeManager Volume manager.
  * @param {function} toggleMode Function to switch to the Slide mode.
  * @constructor
  */
 function MosaicMode(
-    container, dataModel, selectionModel, metadataCache, toggleMode) {
+    container, dataModel, selectionModel, metadataCache, volumeManager,
+    toggleMode) {
   this.mosaic_ = new Mosaic(
-      container.ownerDocument, dataModel, selectionModel, metadataCache);
+      container.ownerDocument, dataModel, selectionModel, metadataCache,
+      volumeManager);
   container.appendChild(this.mosaic_);
 
   this.toggleMode_ = toggleMode;
   this.mosaic_.addEventListener('dblclick', this.toggleMode_);
   this.showingTimeoutID_ = null;
 }
 
 /**
  * @return {Mosaic} The mosaic control.
  */
@@ skipping 37 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 
 /**
  * Mosaic control.
  *
  * @param {Document} document Document.
  * @param {cr.ui.ArrayDataModel} dataModel Data model.
  * @param {cr.ui.ListSelectionModel} selectionModel Selection model.
  * @param {MetadataCache} metadataCache Metadata cache.
+ * @param {VolumeManagerWrapper} volumeManager Volume manager.
  * @return {Element} Mosaic element.
  * @constructor
  */
-function Mosaic(document, dataModel, selectionModel, metadataCache) {
+function Mosaic(document, dataModel, selectionModel, metadataCache,
+    volumeManager) {
   var self = document.createElement('div');
-  Mosaic.decorate(self, dataModel, selectionModel, metadataCache);
+  Mosaic.decorate(
+      self, dataModel, selectionModel, metadataCache, volumeManager);
   return self;
 }
 
 /**
  * Inherits from HTMLDivElement.
  */
 Mosaic.prototype.__proto__ = HTMLDivElement.prototype;
 
 /**
  * Default layout delay in ms.
@@ skipping 10 matching lines @@
  */
 Mosaic.ANIMATED_SCROLL_DURATION = 500;
 
 /**
  * Decorates a Mosaic instance.
  *
  * @param {Mosaic} self Self pointer.
  * @param {cr.ui.ArrayDataModel} dataModel Data model.
  * @param {cr.ui.ListSelectionModel} selectionModel Selection model.
  * @param {MetadataCache} metadataCache Metadata cache.
+ * @param {VolumeManagerWrapper} volumeManager Volume manager.
  */
-Mosaic.decorate = function(self, dataModel, selectionModel, metadataCache) {
+Mosaic.decorate = function(
+    self, dataModel, selectionModel, metadataCache, volumeManager) {
   self.__proto__ = Mosaic.prototype;
   self.className = 'mosaic';
 
   self.dataModel_ = dataModel;
   self.selectionModel_ = selectionModel;
   self.metadataCache_ = metadataCache;
+  self.volumeManager_ = volumeManager;

[hirono, 2014/01/09 04:05:39]

Is this member used?

[mtomasz, 2014/01/10 01:40:10]

Yes, in #149.

 
   // Initialization is completed lazily on the first call to |init|.
 };
 
 /**
  * Initializes the mosaic element.
  */
 Mosaic.prototype.init = function() {
   if (this.tiles_)
     return; // Already initialized, nothing to do.
 
   this.layoutModel_ = new Mosaic.Layout();
   this.onResize_();
 
   this.selectionController_ =
       new Mosaic.SelectionController(this.selectionModel_, this.layoutModel_);
 
   this.tiles_ = [];
-  for (var i = 0; i !== this.dataModel_.length; i++)
-    this.tiles_.push(new Mosaic.Tile(this, this.dataModel_.item(i)));
+  for (var i = 0; i !== this.dataModel_.length; i++) {
+    var locationInfo =
+        this.volumeManager_.getLocationInfo(this.dataModel_.item(i).getEntry());
+    this.tiles_.push(
+        new Mosaic.Tile(this, this.dataModel_.item(i), locationInfo));
+  }
 
   this.selectionModel_.selectedIndexes.forEach(function(index) {
     this.tiles_[index].select(true);
   }.bind(this));
 
   this.initTiles_(this.tiles_);
 
   // The listeners might be called while some tiles are still loading.
   this.initListeners_();
 };
@@ skipping 1465 matching lines @@
   }
 };
 
 ////////////////////////////////////////////////////////////////////////////////
 
 /**
  * A single tile of the image mosaic.
  *
  * @param {Element} container Container element.
  * @param {Gallery.Item} item Gallery item associated with this tile.
+ * @param {EntryLocation} locationInfo Location information for the tile.

[hirono, 2014/01/09 04:05:39]

How about passing hidpiEmbedded flag instead of location information?
It reduces dependency.

[mtomasz, 2014/01/10 01:40:10]

I was thinking about it. This would limit dependencies, but spread
responsibilities over multiple classes. Determining if hidpi is enabled should
be done by the tile class in my opinion. I think LocationInfo is lightweight
enough to be passed. WDYT?

[hirono, 2014/01/10 03:18:23]

So how about getting the flag in the constructor or the decorate method? It also
reduces the dependency but spreads the responsibilities.

  * @return {Element} The new tile element.
  * @constructor
  */
-Mosaic.Tile = function(container, item) {
+Mosaic.Tile = function(container, item, locationInfo) {
   var self = container.ownerDocument.createElement('div');
-  Mosaic.Tile.decorate(self, container, item);
+  Mosaic.Tile.decorate(self, container, item, locationInfo);
   return self;
 };
 
 /**
  * @param {Element} self Self pointer.
  * @param {Element} container Container element.
  * @param {Gallery.Item} item Gallery item associated with this tile.
+ * @param {EntryLocation} locationInfo Location info for the tile image.
  */
-Mosaic.Tile.decorate = function(self, container, item) {
+Mosaic.Tile.decorate = function(self, container, item, locationInfo) {
   self.__proto__ = Mosaic.Tile.prototype;
   self.className = 'mosaic-tile';
 
   self.container_ = container;
   self.item_ = item;
+  self.locationInfo_ = locationInfo;
   self.left_ = null; // Mark as not laid out.
 };
 
 /**
  * Load mode for the tile's image.
  * @enum {number}
  */
 Mosaic.Tile.LoadMode = {
   LOW_DPI: 0,
   HIGH_DPI: 1
@@ skipping 115 matching lines @@
  * @param {function()} onImageMeasured Image measured callback.
  */
 Mosaic.Tile.prototype.init = function(metadata, onImageMeasured) {
   this.markUnloaded();
   this.left_ = null;  // Mark as not laid out.
 
   // Set higher priority for the selected elements to load them first.
   var priority = this.getAttribute('selected') ? 2 : 3;
 
   // Use embedded thumbnails on Drive, since they have higher resolution.
-  // TODO(mtomasz): Use Entry instead of paths.
-  var hidpiEmbedded =
-      PathUtil.isDriveBasedPath(this.getItem().getEntry().fullPath);
+  var hidpiEmbedded = this.locationInfo_ && this.locationInfo_.isDriveBased;
   this.thumbnailLoader_ = new ThumbnailLoader(
       this.getItem().getEntry(),
       ThumbnailLoader.LoaderType.CANVAS,
       metadata,
       undefined,  // Media type.
       hidpiEmbedded ? ThumbnailLoader.UseEmbedded.USE_EMBEDDED :
                       ThumbnailLoader.UseEmbedded.NO_EMBEDDED,
       priority);
 
   // If no hidpi embedded thumbnail available, then use the low resolution
@@ skipping 212 matching lines @@
   return new Rect(this.left_ - this.container_.scrollLeft, this.top_,
       this.width_, this.height_).inflate(-margin, -margin);
 };
 
 /**
  * @return {number} X coordinate of the tile center.
  */
 Mosaic.Tile.prototype.getCenterX = function() {
   return this.left_ + Math.round(this.width_ / 2);
 };