Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303823004: [bindings] Replace last traces of v8::Handle to v8::Local (Closed)

Created:
5 years, 4 months ago by vivekg_samsung
Modified:
5 years, 4 months ago
Reviewers:
haraken, vivekg
CC:
vivekg, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Replace last traces of v8::Handle to v8::Local R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/bindings/core/v8/ScriptFunctionCall.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMDataView.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
vivekg
Trivial one. PTAL.
5 years, 4 months ago (2015-08-20 11:44:47 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-20 11:45:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303823004/1
5 years, 4 months ago (2015-08-20 11:46:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/58211)
5 years, 4 months ago (2015-08-20 17:47:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303823004/1
5 years, 4 months ago (2015-08-20 18:19:52 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 00:26:38 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200942

Powered by Google App Engine
This is Rietveld 408576698