Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1303813005: Revert of Fix UMA to track video data usage. (Closed)

Created:
5 years, 4 months ago by lfg
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix UMA to track video data usage. (patchset #9 id:160001 of https://codereview.chromium.org/1286643002/ ) Reason for revert: After this patch, we try to look for an entry "data_reduction.daily_original_length_application" in data_reduction_proxy::DataReductionProxyCompressionStats::pref_map_ that doesn't exist and crash on data_reduction_proxy::DataReductionProxyCompressionStats::GetInt64. Crash only shows up in debug. Here's a backtrace: #0 0x00007ffff0010cc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x00007ffff00140d8 in __GI_abort () at abort.c:89 #2 0x00007ffff0664fc5 in __gnu_debug::_Error_formatter::_M_error (this=0x7fffffffb1d8) at ../../../../../src/libstdc++-v3/src/c++11/debug.cc:781 #3 0x000055555e4a5b3a in __gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<char const* const, long> >, std::__debug::map<char const*, long, std::less<char const*>, std::allocator<std::pair<char const* const, long> > > >::operat or-> (this=0x7fffffffb448) at /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/debug/safe_iterator.h:277 #4 0x000055555e4a0003 in data_reduction_proxy::DataReductionProxyCompressionStats::GetInt64 (this=0x2f5b919fc560, pref_path=0x555562293980 <data_reduction_proxy::prefs::kDailyHttpOriginalContentLengthApplication> "data_reduction.daily_original_length_application") at ../../components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:475 #5 0x000055555e4a233b in data_reduction_proxy::DataReductionProxyCompressionStats::IncrementInt64Pref (this=0x2f5b919fc560, pref_path=0x555562293980 <data_reduction_proxy::prefs::kDailyHttpOriginalContentLengthApplication> "data_reduction.daily_original_length_application", pref_increment=54546) at ../../components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:492 #6 0x000055555e4a481a in data_reduction_proxy::DataReductionProxyCompressionStats::IncrementDailyUmaPrefs (this=0x2f5b919fc560, original_size=54546, received_size=54546, original_size_pref=0x555562293980 <data_reduction_proxy::prefs::kDailyHttpOriginalContentLengthApplication> "data_reduction.daily_original_length_application", received_size_pref=0x555562293a50 <data_reduction_proxy::prefs::kDailyHttpReceivedContentLengthApplication> "data_reduction.daily_received_length_application", data_reduction_proxy_enabled=false, original_size_with_proxy_enabled_pref=0x555562293c70 <data_reduction_proxy::prefs::kDailyOriginalContentLengthWithDataReductionProxyEnabledApplication> "data_reduction.daily_original_length_with_data_reduction_proxy_enabled_application ", recevied_size_with_proxy_enabled_pref=0x555562293830 <data_reduction_proxy::prefs::kDailyContentLengthWithDataReductionProxyEnabledApplication> "data_reduction.daily_received_length_with_data_reduction_proxy_enabled_application", via_data_reduction_proxy=false, original_size_via_proxy_pref=0x555562293b30 <data_reduction_proxy::prefs::kDailyOriginalContentLengthViaDataReductionProxyApplication> "data_reduction.daily_original_length_via_data_reduction_proxy_application", received_size_via_proxy_pref=0x5555622936f0 <data_reduction_proxy::prefs::kDailyContentLengthViaDataReductionProxyApplication> "data_reduction.daily_received_length_via_data_reduction_proxy_application") at ../../components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:1029 #7 0x000055555e4a2041 in data_reduction_proxy::DataReductionProxyCompressionStats::RecordRequestSizePrefs (this=0x2f5b919fc560, data_used=54546, original_size=54546, with_data_reduction_proxy_enabled=false, Python Exception <class 'gdb.error'> No type "Time" within class or namespace "base".: request_type=data_reduction_proxy::HTTPS, mime_type="application/json", now=...) at ../../components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:971 #8 0x000055555e49fe70 in data_reduction_proxy::DataReductionProxyCompressionStats::UpdateContentLengths (this=0x2f5b919fc560, data_used=54546, original_size=54546, data_reduction_proxy_enabled=false, request_type=data_reduction_proxy::HTTPS, data_usage_host="www.google.ca", mime_type="application/json") at ../../components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:455 #9 0x000055555e4c56a0 in data_reduction_proxy::DataReductionProxyService::UpdateContentLengths (this=0x2f5b9147d160, data_used=54546, original_size=54546, data_reduction_proxy_enabled=false, request_type=data_reduction_proxy::HTTPS, data_usage_host="www.google.ca", mime_type="application/json") at ../../components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc:109 #10 0x000055555e4ba565 in base::internal::RunnableAdapter<void (data_reduction_proxy::DataReductionProxyService::*)(long, long, bool, data_reduction_proxy::DataReductionProxyRequestType, std::string const&, std::string const&)>::Run ( this=0x7fffffffc240, object=0x2f5b9147d160, args=..., args=..., args=..., args=..., args=..., args=...) at ../../base/bind_internal.h:176 Original issue's description: > Fix UMA to track video data usage. > > Add prefs to store data usage for mime-types used by video content. Write the data from prefs to UMA once a day. > The initial implementation of video data usage UMAs was incorrect since it was not maintaining historic data, and was incorrectly assigning data usage to the mime type of the request which triggered reporting. > > BUG=516822, 481025 > > Committed: https://crrev.com/dde0c436fe9c4f95b826bbeb779e77fcff657305 > Cr-Commit-Position: refs/heads/master@{#344515} TBR=bengr@chromium.org,kundaji@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516822, 481025 Committed: https://crrev.com/ef9930e45592f2f729c073c29b4b18b35ae6e332 Cr-Commit-Position: refs/heads/master@{#344583}

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
lfg
Created Revert of Fix UMA to track video data usage.
5 years, 4 months ago (2015-08-20 20:48:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303813005/1
5 years, 4 months ago (2015-08-20 20:48:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 20:50:48 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 20:51:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef9930e45592f2f729c073c29b4b18b35ae6e332
Cr-Commit-Position: refs/heads/master@{#344583}

Powered by Google App Engine
This is Rietveld 408576698