Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: content/public/test/mock_render_thread.cc

Issue 1303773002: Give the main frame a RenderWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/mock_render_thread.cc
diff --git a/content/public/test/mock_render_thread.cc b/content/public/test/mock_render_thread.cc
index dee8514b68c6108e252a3bf5b467c706dac67f61..9e14339f355b1b34393ddbb62b50b5f169a6db42 100644
--- a/content/public/test/mock_render_thread.cc
+++ b/content/public/test/mock_render_thread.cc
@@ -215,14 +215,12 @@ void MockRenderThread::OnCreateWidget(int opener_id,
// The View expects to be returned a valid route_id different from its own.
void MockRenderThread::OnCreateWindow(
const ViewHostMsg_CreateWindow_Params& params,
- int* route_id,
- int* main_frame_route_id,
- int* surface_id,
- int64* cloned_session_storage_namespace_id) {
- *route_id = new_window_routing_id_;
- *main_frame_route_id = new_window_main_frame_routing_id_;
- *surface_id = surface_id_;
- *cloned_session_storage_namespace_id = 0;
+ ViewHostMsg_CreateWindow_Reply* reply) {
+ reply->route_id = new_window_routing_id_;
+ reply->main_frame_route_id = new_window_main_frame_routing_id_;
+ // TODO(dcheng): Set main_frame_widget_route_id too??
ncarter (slow) 2015/08/24 20:55:35 You ought to at least set it to something, I think
dcheng 2015/09/03 16:33:09 Done.
+ reply->surface_id = surface_id_;
+ reply->cloned_session_storage_namespace_id = 0;
}
// The Frame expects to be returned a valid route_id different from its own.

Powered by Google App Engine
This is Rietveld 408576698