ui/views/controls/webview/web_dialog_view.cc - Issue 1303773002: Give the main frame a RenderWidget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/webview/web_dialog_view.cc

Issue 1303773002: Give the main frame a RenderWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix all the tests. Probably. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/webview/web_dialog_view.cc

diff --git a/ui/views/controls/webview/web_dialog_view.cc b/ui/views/controls/webview/web_dialog_view.cc

index 4b5e8b2ebcd1cd47d0d1ae4afdef9ca3af878336..f5e42c79d1c954f047e19e28b7a0478f6332a138 100644

--- a/ui/views/controls/webview/web_dialog_view.cc

+++ b/ui/views/controls/webview/web_dialog_view.cc

@@ -334,8 +334,9 @@ void WebDialogView::BeforeUnloadFired(content::WebContents* tab,

bool WebDialogView::ShouldCreateWebContents(

content::WebContents* web_contents,

- int route_id,

- int main_frame_route_id,

+ int32 route_id,

+ int32 main_frame_route_id,

+ int32 main_frame_widget_route_id,

WindowContainerType window_container_type,

const std::string& frame_name,

const GURL& target_url,