extensions/browser/guest_view/extension_options/extension_options_guest.h - Issue 1303773002: Give the main frame a RenderWidget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 1303773002: Give the main frame a RenderWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: plumb through surface ID *and* widget surface ID for window.open Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/test/render_view_test.cc ('K') | « content/test/test_web_contents.cc ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_options/extension_options_guest.h

diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.h b/extensions/browser/guest_view/extension_options/extension_options_guest.h

index 9cf37d26f21489e705af664a25d69837d409c2ab..9e917ef8b8b6174888cea84448cb42f020fe0016 100644

--- a/extensions/browser/guest_view/extension_options/extension_options_guest.h

+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.h

@@ -43,8 +43,10 @@ class ExtensionOptionsGuest

bool HandleContextMenu(const content::ContextMenuParams& params) override;

bool ShouldCreateWebContents(

content::WebContents* web_contents,

- int route_id,

- int main_frame_route_id,

+ int32 route_id,

+ int32 main_frame_route_id,

+ int32 main_frame_widget_route_id,

+ int32 surface_id,

WindowContainerType window_container_type,

const std::string& frame_name,

const GURL& target_url,