content/renderer/render_widget.cc - Issue 1303773002: Give the main frame a RenderWidget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_widget.cc

Issue 1303773002: Give the main frame a RenderWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: plumb through surface ID *and* widget surface ID for window.open Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_widget.cc

diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc

index 285ca7f68e4847b0a02ed4ef02767444c6537b33..9bac2fd2ff740bf1c9b662f7553149aaef25578c 100644

--- a/content/renderer/render_widget.cc

+++ b/content/renderer/render_widget.cc

@@ -587,6 +587,11 @@ RenderWidget* RenderWidget::CreateForFrame(

blink::WebWidget* RenderWidget::CreateWebFrameWidget(

RenderWidget* render_widget,

blink::WebLocalFrame* frame) {

+ if (!frame->parent()) {

+ // TODO(dcheng): The main frame widget currently has a special case.

+ // Eliminate this once WebView is no longer a WebWidget.

+ return blink::WebFrameWidget::create(render_widget, frame->view(), frame);

+ }

return blink::WebFrameWidget::create(render_widget, frame);

}