Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: content/public/test/render_view_test.cc

Issue 1303773002: Give the main frame a RenderWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: plumb through surface ID *and* widget surface ID for window.open Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/render_view_test.cc
diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc
index daa4a445c8f92a19c305f367fab8a943b050f917..113328160e59d3ba8414fb6711dc264354abb61f 100644
--- a/content/public/test/render_view_test.cc
+++ b/content/public/test/render_view_test.cc
@@ -61,6 +61,7 @@ namespace {
const int32 kRouteId = 5;
const int32 kMainFrameRouteId = 6;
+const int32 kMainFrameWidgetRouteId = 8;
const int32 kNewWindowRouteId = 7;
const int32 kNewFrameRouteId = 10;
const int32 kSurfaceId = 42;
@@ -209,6 +210,8 @@ void RenderViewTest::SetUp() {
render_thread_->set_routing_id(kRouteId);
render_thread_->set_surface_id(kSurfaceId);
render_thread_->set_new_window_routing_id(kNewWindowRouteId);
+ render_thread_->set_new_window_main_frame_widget_routing_id(
+ kMainFrameWidgetRouteId);
render_thread_->set_new_frame_routing_id(kNewFrameRouteId);
#if defined(OS_MACOSX)
@@ -245,9 +248,11 @@ void RenderViewTest::SetUp() {
view_params.renderer_preferences = RendererPreferences();
view_params.web_preferences = WebPreferences();
view_params.view_id = kRouteId;
+ view_params.view_surface_id = kSurfaceId;
view_params.main_frame_routing_id = kMainFrameRouteId;
- view_params.surface_id = kSurfaceId;
+ view_params.main_frame_widget_routing_id = kMainFrameWidgetRouteId;
view_params.session_storage_namespace_id = kInvalidSessionStorageNamespaceId;
+ view_params.widget_surface_id = kSurfaceId + 1;
ncarter (slow) 2015/09/03 20:24:37 Same question here: how much of a hack is this? Ca
dcheng 2015/09/03 21:29:24 Same.
view_params.swapped_out = false;
view_params.replicated_frame_state = FrameReplicationState();
view_params.proxy_routing_id = MSG_ROUTING_NONE;

Powered by Google App Engine
This is Rietveld 408576698