Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: content/public/browser/web_contents.h

Issue 1303773002: Give the main frame a RenderWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: plumb through surface ID *and* widget surface ID for window.open Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index 47decf4c6ea90c6e5f2cc716adf666cc9073014b..48fad2f9dce819cd705803d9c10fab63987fdedf 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -112,11 +112,15 @@ class WebContents : public PageNavigator,
// (e.g., for blocked popups).
bool created_with_opener;
- // The routing ids of the RenderView and of the main RenderFrame. Either
- // both must be provided, or both must be MSG_ROUTING_NONE to have the
- // WebContents make the assignment.
- int routing_id;
- int main_frame_routing_id;
+ // The routing ids of the RenderView, main RenderFrame, and the widget for
+ // the main RenderFrame. Either all routing IDs must be provided or all must
+ // be MSG_ROUTING_NONE to have WebContents make the assignment.
ncarter (slow) 2015/09/03 20:24:37 Maybe the documentation should probably say which
dcheng 2015/09/03 21:29:24 Done, though it's actually for site_instance->GetP
+ int32 routing_id;
+ int32 main_frame_routing_id;
+ int32 main_frame_widget_routing_id;
+
+ // The surface ID of the main frame widget.
ncarter (slow) 2015/09/03 20:24:37 Add a comment saying when this must be provided (i
dcheng 2015/09/03 21:29:24 Done.
+ int32 surface_id;
// The name of the top-level frame of the new window. It is non-empty
// when creating a named window (e.g. <a target="foo"> or

Powered by Google App Engine
This is Rietveld 408576698