content/browser/renderer_host/render_message_filter.h - Issue 1303773002: Give the main frame a RenderWidget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_message_filter.h

Issue 1303773002: Give the main frame a RenderWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: plumb through surface ID *and* widget surface ID for window.open Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_message_filter.h

diff --git a/content/browser/renderer_host/render_message_filter.h b/content/browser/renderer_host/render_message_filter.h

index 3943c1461cd6ddcd6782516bddea75b58c1d15c3..97222e8d214a4cc0697acba3ba5d449b976cae3d 100644

--- a/content/browser/renderer_host/render_message_filter.h

+++ b/content/browser/renderer_host/render_message_filter.h

@@ -48,6 +48,7 @@

class GURL;

struct FontDescriptor;

struct ViewHostMsg_CreateWindow_Params;

+struct ViewHostMsg_CreateWindow_Reply;

namespace blink {

struct WebScreenInfo;

@@ -133,10 +134,7 @@ class CONTENT_EXPORT RenderMessageFilter : public BrowserMessageFilter {

void OnGetProcessMemorySizes(size_t* private_bytes, size_t* shared_bytes);

void OnCreateWindow(const ViewHostMsg_CreateWindow_Params& params,

- int* route_id,

- int* main_frame_route_id,

- int* surface_id,

- int64* cloned_session_storage_namespace_id);

+ ViewHostMsg_CreateWindow_Reply* reply);

void OnCreateWidget(int opener_id,

blink::WebPopupType popup_type,

int* route_id,