Compile OpenSSL for NaCl

openssl_nacl.gyp

Index: openssl_nacl.gyp
diff --git a/openssl_nacl.gyp b/openssl_nacl.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..e89a4b4a941ea27b2507e3e03138101b75977ebc
--- /dev/null
+++ b/openssl_nacl.gyp
@@ -0,0 +1,67 @@
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+{
+  'variables': {
+    'werror': '',

[wtc, 2014/01/10 00:31:03]

Just curious: what is 'werror'?

[Sergey Ulanov, 2014/01/10 01:35:29]

It's necessary for untrusted.gypi to remove -werror compiler flags which makes
the compiler treat warnings as errors. Anyway, I updated this defines to make
sure we compile without warnings (there was warning about redefined
_XOPEN_SOURCE), so this is no longer needed. removed it.

+  },
+  'includes': [
+    '../../native_client/build/untrusted.gypi',
+  ],
+  'targets': [
+    {
+      'target_name': 'openssl_nacl',
+      'type': 'none',
+      'variables': {
+        'nlib_target': 'libopenssl_nacl.a',
+        'build_glibc': 0,
+        'build_newlib': 0,
+        'build_pnacl_newlib': 1,
+      },
+      'dependencies': [
+        '<(DEPTH)/native_client/tools.gyp:prep_toolchain',
+        '<(DEPTH)/native_client_sdk/native_client_sdk_untrusted.gyp:nacl_io_untrusted',
+      ],
+      'includes': [
+        # Include the auto-generated gypi file.
+        'openssl.gypi'

[wtc, 2014/01/10 00:31:03]

In third_party/openssl/openssl.gyp, this line is a (relative) pathname:

        '../../third_party/openssl/openssl.gypi'

Should we change that to the simple filename that you are using here?

[Sergey Ulanov, 2014/01/10 01:35:29]

Done.

+      ],
+      'sources': [
+        '<@(openssl_common_sources)',
+      ],
+      'defines': [
+        '<@(openssl_common_defines)',
+        'MONOLITH',
+        'NO_SYS_UN_H',
+        'NO_SYSLOG',
+        'OPENSSL_NO_ASM',
+        'PURIFY',
+        'TERMIOS',
+        'SSIZE_MAX=INT_MAX',

[wtc, 2014/01/10 00:31:03]

Just curious: why do you need the following?
    'NO_SYS_UN_H',
    'NO_SYSLOG',
    'TERMIOS',
    'SSIZE_MAX=INT_MAX',

They are not in third_party/openssl/openssl.gyp.

[Sergey Ulanov, 2014/01/10 01:35:29]

NaCl toolchain doesn't have some headers that are available to native builds.
E.g. there is no syslog.h (that's why I need NO_SYSLOG). Similarly there is no
TERMIO, but it does have TERMIOS. SSIZE_MAX=INT_MAX is needed because NaCl
headers don't define SSIZE_MAX.

+      ],
+      'defines!': [
+        'TERMIO',
+      ],
+      'include_dirs': [
+        '.',
+        'openssl',
+        'openssl/crypto',
+        'openssl/crypto/asn1',
+        'openssl/crypto/evp',
+        'openssl/crypto/modes',
+        'openssl/include',
+      ],
+      'direct_dependent_settings': {
+        'include_dirs': [
+          'openssl/include',
+        ],
+      },
+      'pnacl_compile_flags': [
+        '-Wno-sometimes-uninitialized'
+      ],
+      '!pnacl_compile_flags': [

[wtc, 2014/01/10 00:31:03]

I am not familiar with GYP syntax, but I have never seen a '!' before a variable
name. Should this be 'pnacl_compile_flags!' ?

[Sergey Ulanov, 2014/01/10 01:35:29]

Yes that was a mistake. I actually meant to write 'pnacl_compile_flags!' here. 
Anyway, the correct thing to do here is to add -Wno-unused-variable in
pnacl_compile_flags . That way it compiles without any warnings.

+        '-Wunused-variable',
+      ],
+    },  # target openssl_nacl
+  ],
+}